Fix Exception catch block for vector-storage connector #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
added
bug
glahaye
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Customer discovered this issue today and it will block anyone who tries to create a new chat.
Description
SK used to throw SKException. Now they are allowing an Azure specific excepetion type to bubble-up for ACS connector and could be anything for different connectors.
This is exacerbated by a second latent SK behavior that a vector-database container/index requires a write before allowing a successful (non-exceptional) read. Previously chat-copilot was catching these exceptions as SKException. Now they are uncaught. This change fixes that.
Contribution Checklist