Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SK to dotnet-0.24.230918.1-preview #369

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

teresaqhoang
Copy link
Contributor

@teresaqhoang teresaqhoang commented Sep 19, 2023

Motivation and Context

This pull request updates the SK package and includes several updates and improvements to the project:

  • Tokenizer change
  • Error handling updates
  • Chat optimizations

Description

  • The SharpToken package has been added, and SemanticKernel packages have been updated to their latest preview versions dotnet-0.24.230918.1-preview.
  • The ChatSkill has been updated to improve performance and bypass audience extraction for the default user.
  • Update TokenUtilities.TokenCount to use custom SharpToken token counter implementation with cl100k_base encoding for calculating the number of tokens in a string, improving the accuracy and consistency of token counting in the project. Remove unused code for determining token usage. Improve error handling by logging and throwing the exception.
  • Refactor ChatController and ChatSkill to use SafeInvokeAsync method for invoking asynchronous callback functions and tagging any exception that occurs with function name. Also, update telemetry tracking accordingly.
  • Update BotResponsePrompt.cs constructor parameter name from systemResponse to systemInstructions
  • Simplified AlertMessage in client
    image

Contribution Checklist

@github-actions github-actions bot added webapi Pull requests that update .net code PR: ready for review labels Sep 19, 2023
@teresaqhoang teresaqhoang self-assigned this Sep 19, 2023
TaoChenOSU
TaoChenOSU previously approved these changes Sep 19, 2023
@github-actions github-actions bot added the webapp Pull requests that update Typescript code label Sep 19, 2023
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Sep 19, 2023
Merged via the queue into microsoft:main with commit c9e585d Sep 19, 2023
8 checks passed
@teresaqhoang teresaqhoang deleted the sk-package-update branch February 21, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapi Pull requests that update .net code webapp Pull requests that update Typescript code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants