Modify deployment scripts to serve static files from web service #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
glahaye
changed the title
github-actions
bot
added
the
github actions
alliscode
reviewed
Sep 25, 2023
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> this PR prepares the frontend for #377 and removes the need for any AAD configuration environment variables. ### Description - removes `REACT_APP_AUTH_TYPE` and all variables starting with `REACT_APP_AAD_` - calls the `/authConfig` endpoint when the app first loads and if needed, renders the `MsalProvider` using the fetched config. - updates workflows and deployment scripts accordingly <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 馃槃
dehoward
requested changes
Oct 5, 2023
glahaye
commented
Oct 6, 2023
dehoward
reviewed
Oct 6, 2023
dehoward
approved these changes
Oct 6, 2023
|
the docs could be updated to reflect the new deployment steps sk-frontend-deployment Also is it required to create 2 separate app registrations, now that both frontend & backend is served from within one appservice |
@raj-microsoft You still need 2 app registrations. The frontend files can be hosted anywhere independently from the backend. They are now hosted by the backend by default to reduce the number of moving parts and to reduce the number of steps required to get to a functional Chat Copilot deployment. Thank you for pointing out the disconnect with the documentation on learn.microsoft.com. I will go and fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change enables having a generic single package containing both backend and frontend that can be deployed using the "Deploy to Azure" button.
It also reduces the complexity and cost of deployments.
Description
Contribution Checklist