Update approach for skipping "summarize" step for memory pipeline #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
webapi
crickman
added
bug
TaoChenOSU
approved these changes
Sep 25, 2023
dluc
reviewed
Sep 25, 2023
| @@ -20,6 +20,8 @@ namespace CopilotChat.WebApi.Extensions; | |||
| /// </summary> | |||
| internal static class ISemanticMemoryClientExtensions | |||
| { | |||
| private static readonly List<string> pipelineSteps = new() { "extract", "partition", "gen_embeddings", "save_embeddings" }; | |||
There was a problem hiding this comment.
FYI there's a constant with these values: Constants.PipelineWithoutSummary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Change to memory pipeline to skip summarize step is being reverted. This is the recommended approach.
Contribution Checklist