Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify if an expr contains errors before checking invertibility #1154

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Verify if an expr contains errors before checking invertibility #1154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f221bf
Before checking invertibility verify if the expr contains errors
Aug 12, 2021
0339e88
Added containsErrors checks to InverUtil::Inverse
Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clang/lib/AST/ExprUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ void ExprUtil::EnsureEqualBitWidths(llvm::APSInt &A, llvm::APSInt &B) {
}

bool InverseUtil::IsInvertible(Sema &S, Expr *LValue, Expr *E) {
if (!E)
if (!E || E->containsErrors())
mgrang marked this conversation as resolved.
Show resolved Hide resolved
return false;

E = E->IgnoreParens();
Expand Down Expand Up @@ -628,7 +628,10 @@ bool InverseUtil::IsCastExprInvertible(Sema &S, Expr *LValue, CastExpr *E) {
}

Expr *InverseUtil::Inverse(Sema &S, Expr *LValue, Expr *F, Expr *E) {
if (!F)
if (!F || F->containsErrors())
return nullptr;

if (!E || E->containsErrors())
return nullptr;

E = E->IgnoreParens();
Expand Down