Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit include of checked header files #440

Merged
merged 8 commits into from
Apr 1, 2021
Merged

Implicit include of checked header files #440

merged 8 commits into from
Apr 1, 2021

Conversation

sulekhark
Copy link
Contributor

Header file changes for the implicit inclusion of checked headers. This PR also deprecates the use of the macro __cplusplus in the header files and uses the new macro __checkedc instead.

@mattmccutchen-cci
Copy link
Member

mattmccutchen-cci commented Mar 18, 2021 •
edited
Loading

Referencing #431 again. Is this ready for us to test (in combination with checkedc/checkedc-clang#998)?

@sulekhark sulekhark changed the title Implicit include of hdrfiles Implicit include of checked header files Mar 18, 2021
@sulekhark
Copy link
Contributor Author

@mattmccutchen-cci Yes, it is. You will need the implicit-include-of-hdrfiles branch on both the checkedc-clang and the checkedc repositories. At present, there is a merge conflict between this branch and master of checkedc-clang for the changes I made in two 3C test cases.

@sulekhark
Some header files like threads.h, unistd.h, arpa/inet.h and sys/socket.h
575f2b0 
may not be present in all compilation environments (Ex. Windows).
Therefore, the wrapper header files and the Checked C header files
should guard their inclusion using __has_include_next.
This will also cause changes in the expected output of some test cases.
@mattmccutchen-cci mattmccutchen-cci mentioned this pull request Mar 22, 2021
Open
@sulekhark
Incorporated review comments.
d372cbe
@sulekhark
The Checked-C-specific declarations in assert_checked.h, stdlib_check…
5a4bcaa 
…ed.h

and inttypes_checked.h use the type wchar_t, whose definition is available
in stddef.h. The file inttypes_checked.h includes stddef.h but the other
two don't.
dtarditi
dtarditi approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@sulekhark sulekhark merged commit f3af449 into master Apr 1, 2021
@sulekhark sulekhark deleted the implicit-include-of-hdrfiles branch April 1, 2021 14:08
This was referenced Apr 1, 2021
Closed
Closed
Open
This was referenced Jan 15, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtarditi dtarditi dtarditi approved these changes

@kkjeer kkjeer Awaiting requested review from kkjeer

@mgrang mgrang Awaiting requested review from mgrang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulekhark @mattmccutchen-cci @dtarditi