Make printf use the platform UART. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
force-pushed
the
printf
branch
2 times, most recently
from
b375231
to
2c959d0
Compare
For historical reasons, this had its own hard-coded version of a 16550. Doing this required making the file C++. At the same time, fix a load of style issue and replace a void* and function pointer with the function wrapper from the network stack. This provides a type-erased way of calling a lambda, so we can clean up the code a bit. Also remove ambient Uart access from this compartment and move the UART access into the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historical reasons, this had its own hard-coded version of a 16550.