Add missing stack check. #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchisnall
force-pushed
the
stack-check
branch
2 times, most recently
from
b864560
to
a675514
Compare
nwf
approved these changes
May 16, 2024
rmn30
approved these changes
May 17, 2024
davidchisnall
force-pushed
the
stack-check
branch
from
a675514
to
4972b0c
Compare
The ABI has included space for the required stack space from the start, but we only recently started putting anything sensible there. It turns out that the switcher was missing this check. This introduces a new errno code to let the caller differentiate between a call that wasn't allowed to proceed and one that crashed. We may want to use this code for other stack badness.
davidchisnall
force-pushed
the
stack-check
branch
from
4972b0c
to
d40b5de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABI has included space for the required stack space from the start, but we only recently started putting anything sensible there. It turns out that the switcher was missing this check.
This introduces a new errno code to let the caller differentiate between a call that wasn't allowed to proceed and one that crashed. We may want to use this code for other stack badness.