Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ThreadPool command to handle both Portable and Windows thread pool #1175

Merged
merged 13 commits into from
Sep 29, 2023

Conversation

eduardo-vp
Copy link
Member

No description provided.

@eduardo-vp eduardo-vp requested a review from kouvel August 15, 2023 03:35
@eduardo-vp eduardo-vp marked this pull request as draft August 15, 2023 03:35
@leculver
Copy link
Contributor

Hey!

I'm in the process of migrating the codebase here over to dotnet/diagnostics. The code will remain the same, but the relative path of the files and location of the repo will change. This will make migrating your change annoying (but not impossible).

Are you ready to wrap up this change? It's no problem if you aren't yet ready.

If you need more time, you may need to generate a patch for the diff (maybe try git format-patch), edit the patch to apply to the new paths in the dotnet/diagnostics repo. I'm happy to help if that's what we need to do.

Thanks!

Copy link
Contributor

@leculver leculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have two minor suggestions.

src/Microsoft.Diagnostics.Runtime/ClrThreadPool.cs Outdated Show resolved Hide resolved
src/Microsoft.Diagnostics.Runtime/ClrThreadPool.cs Outdated Show resolved Hide resolved
@eduardo-vp eduardo-vp merged commit 547545a into microsoft:main Sep 29, 2023
8 checks passed
mikem8361 added a commit to dotnet/diagnostics that referenced this pull request Sep 30, 2023
…nd when using the Windows thread pool (#4160)

Uses the properties exposed in
microsoft/clrmd#1175 to show relevant Windows
thread pool information if it's enabled

---------

Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants