Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure and deploy an Azure App Service #74

Merged
merged 22 commits into from
May 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1560daf
Add App Service to Azure using Terraform Templates
manojvazirani Apr 16, 2019
915db60
Add App Service under App Service Plan module
manojvazirani Apr 17, 2019
21f6622
Merge branch 'mavazira/features/appsvc' of github.com:Microsoft/entre…
manojvazirani Apr 17, 2019
c2ae75c
Remove additional files for app-service created
manojvazirani Apr 17, 2019
75349a7
Add public Ip and load balancer to app service
manojvazirani Apr 17, 2019
8f06b15
Merge branch 'master' of github.com:Microsoft/entref-appservice-conta…
manojvazirani Apr 22, 2019
9956e8f
Add svcplan changes and optional settings to appsvc
manojvazirani Apr 22, 2019
abbf4cb
Integrate review comments related to naming of resources
manojvazirani Apr 23, 2019
9ae78d9
Resolve merge issues with master
manojvazirani Apr 23, 2019
f0b3190
Remove Optional and Required from variables.tf
manojvazirani Apr 24, 2019
e023a40
Update variables.tf
manojvazirani Apr 24, 2019
0f58958
App service acts as load balancer
manojvazirani Apr 24, 2019
d5eee4e
Merge branch 'mavazira/features/appsvc' of github.com:Microsoft/entre…
manojvazirani Apr 24, 2019
5731e96
Add App Service as an independent module
manojvazirani Apr 24, 2019
caad189
Merge branch 'master' of github.com:Microsoft/entref-appservice-conta…
manojvazirani Apr 24, 2019
8c5160d
Fix Merge conflicts
manojvazirani Apr 24, 2019
d9a5c17
Add multiple App Service Deployment Changes
manojvazirani Apr 25, 2019
a990bea
Add type for every variable in variables.tf
manojvazirani Apr 26, 2019
cf12dea
Merge branch 'master' of github.com:Microsoft/entref-appservice-conta…
manojvazirani Apr 29, 2019
4c4348b
Update to documentation for usage
manojvazirani Apr 29, 2019
2b8c7df
Integrate review comments for Docker credentials
manojvazirani Apr 30, 2019
d2215f7
Create app service map with image tags
manojvazirani Apr 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions infra/modules/providers/azure/app-service/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
## Azure App Service

Build, deploy, and scale enterprise-grade web, mobile, and API apps running on any platform. Meet rigorous performance, scalability, security and compliance requirements while using a fully managed platform to perform infrastructure maintenance.

More information for Azure App Services can be found [here](https://azure.microsoft.com/en-us/services/app-service/)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note, please update the usage section of the readme for the service plan module so that cobalt users have more context on how to define and configure there module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me open a new PR with the documentation changes for service plan.

Cobalt gives ability to specify following settings for App Service based on the requirements:
- name : The name of the App Services to be created. This is a map of app service name and the linux_fx_version/container image to be loaded for that app service. DOCKER|<user/image:tag>
- service_plan_resource_group_name : The Name of the Resource Group where the Service Plan exists.
- app_service_plan_id : The ID of the App Service Plan within which the App Service exists is populated automatically based on service plan.
- tags : A mapping of tags to assign to the resource.
- app_settings : A key-value pair of App Settings. Settings for private Container Registries
- DOCKER_REGISTRY_SERVER_URL : The docker registry server URL for app service to be created
- DOCKER_REGISTRY_SERVER_USERNAME : The docker registry server usernames for app services to be created
- DOCKER_REGISTRY_SERVER_PASSWORD : The docker registry server passwords for app services to be created
- site_config :
- always_on : Should the app be loaded at all times? Defaults to false.
- virtual_network_name : The name of the Virtual Network which this App Service should be attached to.

Please click the [link](https://www.terraform.io/docs/providers/azurerm/d/app_service.html) to get additional details on settings in Terraform for Azure App Service.

## Usage
erikschlegel marked this conversation as resolved.
Show resolved Hide resolved

### Module Definitions

The App Service is dependent on deployment of Service Plan. Make sure to deploy Service Plan before starting to deploy App Services.

- Service Plan Module : infra/modules/providers/azure/service-plan
- App Service Module : infra/modules/providers/azure/app-service

```
variable "resource_group_name" {
value = "test-rg"
}
variable "service_plan_name" {
value = "test-svcplan"
}
variable "app_service_name" {
value = {
appservice1="DOCKER|<user1/image1:tag1>"
appservice2="DOCKER|<user2/image2:tag2>"
}
}
module "service_plan" {
resource_group_name = "${var.resource_group_name}"
resource_group_location = "${var.resource_group_location}"
service_plan_name = "${var.service_plan_name}"
}
module "app_service" {
service_plan_resource_group_name = "${var.resource_group_name}"
service_plan_name = "${var.service_plan_name}"
```

## Outputs

Once the deployments are completed successfully, the output for the current module will be in the format mentioned below:

```
Outputs:
app_service_uri = [
appservice1.azurewebsites.net,
appservice2.azurewebsites.net
]
```
29 changes: 29 additions & 0 deletions infra/modules/providers/azure/app-service/main.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
data "azurerm_resource_group" "appsvc" {
name = "${var.service_plan_resource_group_name}"
}

data "azurerm_app_service_plan" "appsvc" {
name = "${var.service_plan_name}"
resource_group_name = "${data.azurerm_resource_group.appsvc.name}"
}

resource "azurerm_app_service" "appsvc" {
name = "${element(keys(var.app_service_name), count.index)}"
resource_group_name = "${data.azurerm_resource_group.appsvc.name}"
location = "${data.azurerm_resource_group.appsvc.location}"
app_service_plan_id = "${data.azurerm_app_service_plan.appsvc.id}"
tags = "${var.resource_tags}"
count = "${length(keys(var.app_service_name))}"

app_settings {
DOCKER_REGISTRY_SERVER_URL = "${var.docker_registry_server_url}"
DOCKER_REGISTRY_SERVER_USERNAME = "${var.docker_registry_server_username}"
DOCKER_REGISTRY_SERVER_PASSWORD = "${var.docker_registry_server_password}"
}

site_config {
linux_fx_version = "${element(values(var.app_service_name), count.index)}"
always_on = "${var.site_config_always_on}"
virtual_network_name = "${var.site_config_vnet_name}"
}
}
5 changes: 5 additions & 0 deletions infra/modules/providers/azure/app-service/output.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
output "app_service_uri" {
description = "The URL of the app service created"
value = "${azurerm_app_service.appsvc.*.default_site_hostname}"
}

51 changes: 51 additions & 0 deletions infra/modules/providers/azure/app-service/variables.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
variable "service_plan_resource_group_name" {
description = "The name of the resource group in which the service plan was created."
type = "string"
}

variable "service_plan_name" {
description = "The name of the service plan"
erikschlegel marked this conversation as resolved.
Show resolved Hide resolved
type = "string"
}

variable "resource_tags" {
description = "Map of tags to apply to taggable resources in this module. By default the taggable resources are tagged with the name defined above and this map is merged in"
type = "map"
default = {}
}

variable "app_service_name" {
description = "The name of the app service to be created"
type = "map"
default = {}
}

variable "docker_registry_server_url" {
description = "The docker registry server URL for app service to be created"
type = "string"
default = "index.docker.io"
}

variable "docker_registry_server_username" {
description = "The docker registry server username for app service to be created"
type = "string"
default = ""
}

variable "docker_registry_server_password" {
description = "The docker registry server password for app service to be created"
type = "string"
default = ""
}

variable "site_config_always_on" {
description = "Should the app be loaded at all times? Defaults to false."
type = "string"
default = "false"
}

variable "site_config_vnet_name" {
description = "Should the app be loaded at all times? Defaults to false."
type = "string"
default = ""
}
2 changes: 1 addition & 1 deletion infra/modules/providers/azure/provider/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ resource "null_resource" "example" {
command = "execute shell script"
}
}
```
```
2 changes: 1 addition & 1 deletion infra/modules/providers/azure/provider/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ provider "null" {

provider "azuread" {
version = "~>0.1"
}
}
18 changes: 12 additions & 6 deletions infra/modules/providers/azure/service-plan/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ variable "resource_group_name" {

variable "resource_group_location" {
description = "Specifies the supported Azure location where the resource exists. Changing this forces a new resource to be created. The full list of Azure regions can be found at https://azure.microsoft.com/regions"
type = "string"
}

variable "resource_tags" {
Expand All @@ -19,26 +20,31 @@ variable "service_plan_name" {
}

variable "service_plan_tier" {
description = "The tier under which the service plan is created. Details can be found at https://docs.microsoft.com/en-us/azure/app-service/overview-hosting-plans"
default = "Isolated"
description = "The tier under which the service plan is created. Details can be found at https://docs.microsoft.com/en-us/azure/app-service/overview-hosting-plans"
manojvazirani marked this conversation as resolved.
Show resolved Hide resolved
type = "string"
default = "Standard"
}

variable "service_plan_size" {
description = "The compute and storage needed for the service plan to be deployed. Details can be found at https://azure.microsoft.com/en-us/pricing/details/app-service/windows/"
default = "S1"
description = "The compute and storage needed for the service plan to be deployed. Details can be found at https://azure.microsoft.com/en-us/pricing/details/app-service/windows/"
type = "string"
default = "S1"
}

variable "service_plan_kind" {
description = "The kind of Service Plan to be created. Possible values are Windows/Linux/FunctionApp/App"
default = "Linux"
description = "The kind of Service Plan to be created. Possible values are Windows/Linux/FunctionApp/App"
erikschlegel marked this conversation as resolved.
Show resolved Hide resolved
type = "string"
default = "Linux"
}

variable "service_plan_capacity" {
description = "The capacity of Service Plan to be created."
type = "number"
default = "1"
}

variable "service_plan_reserved" {
description = "Is the Service Plan to be created reserved. Possible values are true/false"
type = "bool"
default = true
}