Ran terraform fmt on all terraform packages
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmiodice
requested review from
erikschlegel,
hxlnt,
TechnicallyWilliams,
ianphil,
code4clouds and
manojvazirani
erikschlegel
approved these changes
May 13, 2019
manojvazirani
pushed a commit
to manojvazirani/entref-appservice-containers
that referenced
this pull request
Jul 16, 2020
* # This is a combination of 99 commits. # This is the 1st commit message: Adding docker test base image # This is the commit message microsoft#2: Adding test files # This is the commit message microsoft#3: testing # This is the commit message microsoft#4: Added folder # This is the commit message microsoft#5: Added folder # This is the commit message microsoft#6: Azure Devops CI Build Pipeline (microsoft#67) * Adding azure devops build pipeline * Adding README * Adding azure build badge # This is the commit message microsoft#7: saving latest tests # This is the commit message microsoft#8: Adding docker test base image (microsoft#68) # This is the commit message microsoft#9: EOD checkin # This is the commit message microsoft#10: posting latest # This is the commit message microsoft#11: eod commits # This is the commit message microsoft#12: eod commit # This is the commit message microsoft#13: refactored test directory structure # This is the commit message microsoft#14: Refactored build # This is the commit message microsoft#15: Adding hello world azure simple app # This is the commit message microsoft#16: Adding hello world azure simple app # This is the commit message microsoft#17: refactoring test harness # This is the commit message microsoft#18: refactoring test harness # This is the commit message microsoft#19: checking latest # This is the commit message microsoft#20: committing latest # This is the commit message microsoft#21: checking in latest changes # This is the commit message microsoft#22: Checking in latest progress # This is the commit message microsoft#23: applying final touches before PR submission # This is the commit message microsoft#24: updating azure keyvault secret names # This is the commit message microsoft#25: Checking in latest progress # This is the commit message microsoft#26: pushing latest pipeline definition # This is the commit message microsoft#27: updating build pipeline variable format # This is the commit message microsoft#28: updating build pipeline variable format # This is the commit message microsoft#29: cleaning up build variables # This is the commit message microsoft#30: adding minor changes to azure build pipeline # This is the commit message microsoft#31: updating azure keyvault secret names # This is the commit message microsoft#32: updating azure keyvault secret names # This is the commit message microsoft#33: fixing docker login azdo step # This is the commit message microsoft#34: fixing docker login azdo step # This is the commit message microsoft#35: fixing docker login azdo step # This is the commit message microsoft#36: fixing docker login azdo step # This is the commit message microsoft#37: updating build pipeline variables # This is the commit message microsoft#38: updating build pipeline variables # This is the commit message microsoft#39: updating build pipeline variables # This is the commit message microsoft#40: updating build pipeline variables # This is the commit message microsoft#41: updating build pipeline variables # This is the commit message microsoft#42: updating build pipeline variables # This is the commit message microsoft#43: applying fix to git diff script # This is the commit message microsoft#44: applying fix to git diff script # This is the commit message microsoft#45: applying fix to git diff script # This is the commit message microsoft#46: applying fix to git diff script # This is the commit message microsoft#47: applying fix to git diff script # This is the commit message microsoft#48: resolving pipeline bug # This is the commit message microsoft#49: fixing build error # This is the commit message microsoft#50: fixing build error # This is the commit message microsoft#51: fixing build error # This is the commit message microsoft#52: fixing build error # This is the commit message microsoft#53: fixing build error # This is the commit message microsoft#54: fixing build error # This is the commit message microsoft#55: fixing build error # This is the commit message microsoft#56: fixing build error # This is the commit message microsoft#57: fixing build error # This is the commit message microsoft#58: fixing build error # This is the commit message microsoft#59: fixing build error # This is the commit message microsoft#60: fixing build error # This is the commit message microsoft#61: fixing build error # This is the commit message microsoft#62: fixing build error # This is the commit message microsoft#63: fixing build error # This is the commit message microsoft#64: fixing build error # This is the commit message microsoft#65: fixing build error # This is the commit message microsoft#66: fixing build error # This is the commit message microsoft#67: fixing build error # This is the commit message microsoft#68: fixing build error # This is the commit message microsoft#69: fixing build error # This is the commit message microsoft#70: fixing build error # This is the commit message microsoft#71: fixing build error # This is the commit message microsoft#72: fixing build error # This is the commit message microsoft#73: trying acr fix # This is the commit message microsoft#74: latest changes # This is the commit message microsoft#75: removing docker dependency on azure devops pipeline # This is the commit message microsoft#76: removing docker dependency on azure devops pipeline # This is the commit message microsoft#77: removing docker dependency on azure devops pipeline # This is the commit message microsoft#78: removing docker dependency on azure devops pipeline # This is the commit message microsoft#79: removing docker dependency on azure devops pipeline # This is the commit message microsoft#80: removing docker dependency on azure devops pipeline # This is the commit message microsoft#81: removing docker dependency on azure devops pipeline # This is the commit message microsoft#82: removing docker dependency on azure devops pipeline # This is the commit message microsoft#83: removing docker dependency on azure devops pipeline # This is the commit message microsoft#84: removing docker dependency on azure devops pipeline # This is the commit message microsoft#85: removing docker dependency on azure devops pipeline # This is the commit message microsoft#86: removing docker dependency on azure devops pipeline # This is the commit message microsoft#87: removing docker dependency on azure devops pipeline # This is the commit message microsoft#88: removing docker dependency on azure devops pipeline # This is the commit message microsoft#89: removing docker dependency on azure devops pipeline # This is the commit message microsoft#90: removing docker dependency on azure devops pipeline # This is the commit message microsoft#91: removing docker dependency on azure devops pipeline # This is the commit message microsoft#92: removing docker dependency on azure devops pipeline # This is the commit message microsoft#93: removing docker dependency on azure devops pipeline # This is the commit message microsoft#94: removing docker dependency on azure devops pipeline # This is the commit message microsoft#95: removing docker dependency on azure devops pipeline # This is the commit message microsoft#96: removing docker dependency on azure devops pipeline # This is the commit message microsoft#97: removing docker dependency on azure devops pipeline # This is the commit message microsoft#98: final commit including resource name randomization # This is the commit message microsoft#99: Add provider to configure az infra for Terraform * resolving merge conflicts for squash Updated documentation based on review comments Integrate review comments for documentation. Add usage example for each of the providers Adding environment template descriptions removing go version var from azdo pipeline as it's unused removing unused setup folder adding more verbose logging for azure devops failure fixing pull request branch name resolution bug fixing pull request branch name resolution bug addressing nick's pr comments documenting script and docker images cleaning up required env var check fixing base branch bug Added service plan terraform templates to Azure Adding tags for resources Integrate review comments to add random id to name Add tags, capacity and reserved for service plan Minor Fixes for documentation Integrate review comments related to resource naming Remove Optional and Required in variables.tf Update variables.tf Update Service Plan Tier to Isolated squaching commits applied base image suggestions from nick * squashing commits and slimming down the build image * removing go* path from azure devops pipeline as we removed go mods * refactoring our azure devops pipeline so it's aligned with the local test runner * fixing azure devops pipeline bug * fixing base image build variable reference bug * Addressing nick's PR comments
manojvazirani
pushed a commit
to manojvazirani/entref-appservice-containers
that referenced
this pull request
Jul 16, 2020
* # This is a combination of 99 commits. # This is the 1st commit message: Adding docker test base image # This is the commit message microsoft#2: Adding test files # This is the commit message microsoft#3: testing # This is the commit message microsoft#4: Added folder # This is the commit message microsoft#5: Added folder # This is the commit message microsoft#6: Azure Devops CI Build Pipeline (microsoft#67) * Adding azure devops build pipeline * Adding README * Adding azure build badge # This is the commit message microsoft#7: saving latest tests # This is the commit message microsoft#8: Adding docker test base image (microsoft#68) # This is the commit message microsoft#9: EOD checkin # This is the commit message microsoft#10: posting latest # This is the commit message microsoft#11: eod commits # This is the commit message microsoft#12: eod commit # This is the commit message microsoft#13: refactored test directory structure # This is the commit message microsoft#14: Refactored build # This is the commit message microsoft#15: Adding hello world azure simple app # This is the commit message microsoft#16: Adding hello world azure simple app # This is the commit message microsoft#17: refactoring test harness # This is the commit message microsoft#18: refactoring test harness # This is the commit message microsoft#19: checking latest # This is the commit message microsoft#20: committing latest # This is the commit message microsoft#21: checking in latest changes # This is the commit message microsoft#22: Checking in latest progress # This is the commit message microsoft#23: applying final touches before PR submission # This is the commit message microsoft#24: updating azure keyvault secret names # This is the commit message microsoft#25: Checking in latest progress # This is the commit message microsoft#26: pushing latest pipeline definition # This is the commit message microsoft#27: updating build pipeline variable format # This is the commit message microsoft#28: updating build pipeline variable format # This is the commit message microsoft#29: cleaning up build variables # This is the commit message microsoft#30: adding minor changes to azure build pipeline # This is the commit message microsoft#31: updating azure keyvault secret names # This is the commit message microsoft#32: updating azure keyvault secret names # This is the commit message microsoft#33: fixing docker login azdo step # This is the commit message microsoft#34: fixing docker login azdo step # This is the commit message microsoft#35: fixing docker login azdo step # This is the commit message microsoft#36: fixing docker login azdo step # This is the commit message microsoft#37: updating build pipeline variables # This is the commit message microsoft#38: updating build pipeline variables # This is the commit message microsoft#39: updating build pipeline variables # This is the commit message microsoft#40: updating build pipeline variables # This is the commit message microsoft#41: updating build pipeline variables # This is the commit message microsoft#42: updating build pipeline variables # This is the commit message microsoft#43: applying fix to git diff script # This is the commit message microsoft#44: applying fix to git diff script # This is the commit message microsoft#45: applying fix to git diff script # This is the commit message microsoft#46: applying fix to git diff script # This is the commit message microsoft#47: applying fix to git diff script # This is the commit message microsoft#48: resolving pipeline bug # This is the commit message microsoft#49: fixing build error # This is the commit message microsoft#50: fixing build error # This is the commit message microsoft#51: fixing build error # This is the commit message microsoft#52: fixing build error # This is the commit message microsoft#53: fixing build error # This is the commit message microsoft#54: fixing build error # This is the commit message microsoft#55: fixing build error # This is the commit message microsoft#56: fixing build error # This is the commit message microsoft#57: fixing build error # This is the commit message microsoft#58: fixing build error # This is the commit message microsoft#59: fixing build error # This is the commit message microsoft#60: fixing build error # This is the commit message microsoft#61: fixing build error # This is the commit message microsoft#62: fixing build error # This is the commit message microsoft#63: fixing build error # This is the commit message microsoft#64: fixing build error # This is the commit message microsoft#65: fixing build error # This is the commit message microsoft#66: fixing build error # This is the commit message microsoft#67: fixing build error # This is the commit message microsoft#68: fixing build error # This is the commit message microsoft#69: fixing build error # This is the commit message microsoft#70: fixing build error # This is the commit message microsoft#71: fixing build error # This is the commit message microsoft#72: fixing build error # This is the commit message microsoft#73: trying acr fix # This is the commit message microsoft#74: latest changes # This is the commit message microsoft#75: removing docker dependency on azure devops pipeline # This is the commit message microsoft#76: removing docker dependency on azure devops pipeline # This is the commit message microsoft#77: removing docker dependency on azure devops pipeline # This is the commit message microsoft#78: removing docker dependency on azure devops pipeline # This is the commit message microsoft#79: removing docker dependency on azure devops pipeline # This is the commit message microsoft#80: removing docker dependency on azure devops pipeline # This is the commit message microsoft#81: removing docker dependency on azure devops pipeline # This is the commit message microsoft#82: removing docker dependency on azure devops pipeline # This is the commit message microsoft#83: removing docker dependency on azure devops pipeline # This is the commit message microsoft#84: removing docker dependency on azure devops pipeline # This is the commit message microsoft#85: removing docker dependency on azure devops pipeline # This is the commit message microsoft#86: removing docker dependency on azure devops pipeline # This is the commit message microsoft#87: removing docker dependency on azure devops pipeline # This is the commit message microsoft#88: removing docker dependency on azure devops pipeline # This is the commit message microsoft#89: removing docker dependency on azure devops pipeline # This is the commit message microsoft#90: removing docker dependency on azure devops pipeline # This is the commit message microsoft#91: removing docker dependency on azure devops pipeline # This is the commit message microsoft#92: removing docker dependency on azure devops pipeline # This is the commit message microsoft#93: removing docker dependency on azure devops pipeline # This is the commit message microsoft#94: removing docker dependency on azure devops pipeline # This is the commit message microsoft#95: removing docker dependency on azure devops pipeline # This is the commit message microsoft#96: removing docker dependency on azure devops pipeline # This is the commit message microsoft#97: removing docker dependency on azure devops pipeline # This is the commit message microsoft#98: final commit including resource name randomization # This is the commit message microsoft#99: Add provider to configure az infra for Terraform * resolving merge conflicts for squash Updated documentation based on review comments Integrate review comments for documentation. Add usage example for each of the providers Adding environment template descriptions removing go version var from azdo pipeline as it's unused removing unused setup folder adding more verbose logging for azure devops failure fixing pull request branch name resolution bug fixing pull request branch name resolution bug addressing nick's pr comments documenting script and docker images cleaning up required env var check fixing base branch bug Added service plan terraform templates to Azure Adding tags for resources Integrate review comments to add random id to name Add tags, capacity and reserved for service plan Minor Fixes for documentation Integrate review comments related to resource naming Remove Optional and Required in variables.tf Update variables.tf Update Service Plan Tier to Isolated squaching commits applied base image suggestions from nick * squashing commits and slimming down the build image * removing go* path from azure devops pipeline as we removed go mods * refactoring our azure devops pipeline so it's aligned with the local test runner * fixing azure devops pipeline bug * fixing base image build variable reference bug * Addressing nick's PR comments * resolving issue with failed builds after completing branches merges * addressing a bug where test harness directory changes were not getting picked up by the harness * removing local echo statement * Adding directory exists check and app service container command variable * addressing nick's PR comments * adding git diff extension whitelist filter
manojvazirani
pushed a commit
to manojvazirani/entref-appservice-containers
that referenced
this pull request
Jul 16, 2020
* # This is a combination of 99 commits. # This is the 1st commit message: Adding docker test base image # This is the commit message microsoft#2: Adding test files # This is the commit message microsoft#3: testing # This is the commit message microsoft#4: Added folder # This is the commit message microsoft#5: Added folder # This is the commit message microsoft#6: Azure Devops CI Build Pipeline (microsoft#67) * Adding azure devops build pipeline * Adding README * Adding azure build badge # This is the commit message microsoft#7: saving latest tests # This is the commit message microsoft#8: Adding docker test base image (microsoft#68) # This is the commit message microsoft#9: EOD checkin # This is the commit message microsoft#10: posting latest # This is the commit message microsoft#11: eod commits # This is the commit message microsoft#12: eod commit # This is the commit message microsoft#13: refactored test directory structure # This is the commit message microsoft#14: Refactored build # This is the commit message microsoft#15: Adding hello world azure simple app # This is the commit message microsoft#16: Adding hello world azure simple app # This is the commit message microsoft#17: refactoring test harness # This is the commit message microsoft#18: refactoring test harness # This is the commit message microsoft#19: checking latest # This is the commit message microsoft#20: committing latest # This is the commit message microsoft#21: checking in latest changes # This is the commit message microsoft#22: Checking in latest progress # This is the commit message microsoft#23: applying final touches before PR submission # This is the commit message microsoft#24: updating azure keyvault secret names # This is the commit message microsoft#25: Checking in latest progress # This is the commit message microsoft#26: pushing latest pipeline definition # This is the commit message microsoft#27: updating build pipeline variable format # This is the commit message microsoft#28: updating build pipeline variable format # This is the commit message microsoft#29: cleaning up build variables # This is the commit message microsoft#30: adding minor changes to azure build pipeline # This is the commit message microsoft#31: updating azure keyvault secret names # This is the commit message microsoft#32: updating azure keyvault secret names # This is the commit message microsoft#33: fixing docker login azdo step # This is the commit message microsoft#34: fixing docker login azdo step # This is the commit message microsoft#35: fixing docker login azdo step # This is the commit message microsoft#36: fixing docker login azdo step # This is the commit message microsoft#37: updating build pipeline variables # This is the commit message microsoft#38: updating build pipeline variables # This is the commit message microsoft#39: updating build pipeline variables # This is the commit message microsoft#40: updating build pipeline variables # This is the commit message microsoft#41: updating build pipeline variables # This is the commit message microsoft#42: updating build pipeline variables # This is the commit message microsoft#43: applying fix to git diff script # This is the commit message microsoft#44: applying fix to git diff script # This is the commit message microsoft#45: applying fix to git diff script # This is the commit message microsoft#46: applying fix to git diff script # This is the commit message microsoft#47: applying fix to git diff script # This is the commit message microsoft#48: resolving pipeline bug # This is the commit message microsoft#49: fixing build error # This is the commit message microsoft#50: fixing build error # This is the commit message microsoft#51: fixing build error # This is the commit message microsoft#52: fixing build error # This is the commit message microsoft#53: fixing build error # This is the commit message microsoft#54: fixing build error # This is the commit message microsoft#55: fixing build error # This is the commit message microsoft#56: fixing build error # This is the commit message microsoft#57: fixing build error # This is the commit message microsoft#58: fixing build error # This is the commit message microsoft#59: fixing build error # This is the commit message microsoft#60: fixing build error # This is the commit message microsoft#61: fixing build error # This is the commit message microsoft#62: fixing build error # This is the commit message microsoft#63: fixing build error # This is the commit message microsoft#64: fixing build error # This is the commit message microsoft#65: fixing build error # This is the commit message microsoft#66: fixing build error # This is the commit message microsoft#67: fixing build error # This is the commit message microsoft#68: fixing build error # This is the commit message microsoft#69: fixing build error # This is the commit message microsoft#70: fixing build error # This is the commit message microsoft#71: fixing build error # This is the commit message microsoft#72: fixing build error # This is the commit message microsoft#73: trying acr fix # This is the commit message microsoft#74: latest changes # This is the commit message microsoft#75: removing docker dependency on azure devops pipeline # This is the commit message microsoft#76: removing docker dependency on azure devops pipeline # This is the commit message microsoft#77: removing docker dependency on azure devops pipeline # This is the commit message microsoft#78: removing docker dependency on azure devops pipeline # This is the commit message microsoft#79: removing docker dependency on azure devops pipeline # This is the commit message microsoft#80: removing docker dependency on azure devops pipeline # This is the commit message microsoft#81: removing docker dependency on azure devops pipeline # This is the commit message microsoft#82: removing docker dependency on azure devops pipeline # This is the commit message microsoft#83: removing docker dependency on azure devops pipeline # This is the commit message microsoft#84: removing docker dependency on azure devops pipeline # This is the commit message microsoft#85: removing docker dependency on azure devops pipeline # This is the commit message microsoft#86: removing docker dependency on azure devops pipeline # This is the commit message microsoft#87: removing docker dependency on azure devops pipeline # This is the commit message microsoft#88: removing docker dependency on azure devops pipeline # This is the commit message microsoft#89: removing docker dependency on azure devops pipeline # This is the commit message microsoft#90: removing docker dependency on azure devops pipeline # This is the commit message microsoft#91: removing docker dependency on azure devops pipeline # This is the commit message microsoft#92: removing docker dependency on azure devops pipeline # This is the commit message microsoft#93: removing docker dependency on azure devops pipeline # This is the commit message microsoft#94: removing docker dependency on azure devops pipeline # This is the commit message microsoft#95: removing docker dependency on azure devops pipeline # This is the commit message microsoft#96: removing docker dependency on azure devops pipeline # This is the commit message microsoft#97: removing docker dependency on azure devops pipeline # This is the commit message microsoft#98: final commit including resource name randomization # This is the commit message microsoft#99: Add provider to configure az infra for Terraform * resolving merge conflicts for squash Updated documentation based on review comments Integrate review comments for documentation. Add usage example for each of the providers Adding environment template descriptions removing go version var from azdo pipeline as it's unused removing unused setup folder adding more verbose logging for azure devops failure fixing pull request branch name resolution bug fixing pull request branch name resolution bug addressing nick's pr comments documenting script and docker images cleaning up required env var check fixing base branch bug Added service plan terraform templates to Azure Adding tags for resources Integrate review comments to add random id to name Add tags, capacity and reserved for service plan Minor Fixes for documentation Integrate review comments related to resource naming Remove Optional and Required in variables.tf Update variables.tf Update Service Plan Tier to Isolated squaching commits applied base image suggestions from nick * squashing commits and slimming down the build image * removing go* path from azure devops pipeline as we removed go mods * refactoring our azure devops pipeline so it's aligned with the local test runner * fixing azure devops pipeline bug * fixing base image build variable reference bug * Addressing nick's PR comments * resolving issue with failed builds after completing branches merges * addressing a bug where test harness directory changes were not getting picked up by the harness * removing local echo statement * Adding directory exists check and app service container command variable * addressing nick's PR comments * adding git diff extension whitelist filter * Overhauling main project readme * Adding james to the readme * Update README.md * Updating readme from the test-harness directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
What is the current behavior?
Terraform files do not adhere to rules defined by
terraform fmtcommand. As a part of #90 I'll be adding linting to TF files. This change is intended to baseline all TF files to a common standard so that the PR for #90 is not cluttered with a bunch of formatting changes.What is the new behavior?
terraform fmtcommand.Does this introduce a breaking change?
Any relevant logs, error output, etc?