Sanitizes Code Reviews README and adds information about metrics #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ME and adds information about CR metrics.
|
Could you link the issues in the "Linked issues" section of the PR pls? |
1 similar comment
|
Could you link the issues in the "Linked issues" section of the PR pls? |
p-schuler
approved these changes
Feb 27, 2020
This was
linked to
issues
Feb 27, 2020
There was a problem hiding this comment.
Looks great.
I just have one concern, there is a PR being reviewed currently on the same readme about size guidance.
Perhaps you should coordinate so that the changes here (or areas that you already checked and feel are ok) don't get overwritten by that as I think a lot of them are in the same sections.
TessFerrandez
added this to Reviewer approved
in Engineering Playbook Backlog
via automation
saroup
suggested changes
Mar 2, 2020
Engineering Playbook Backlog
automation
moved this from Reviewer approved
to Needs review
Mar 2, 2020
|
Closing this PR as it has become convoluted, and starting fresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #168 and #120