Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diagram tooling to include Visio or PowerPoint #922

Merged
merged 3 commits into from Jan 23, 2023
Merged

Update diagram tooling to include Visio or PowerPoint #922

merged 3 commits into from Jan 23, 2023

Conversation

benjguin
Copy link
Member

@benjguin benjguin commented Jan 20, 2023 •
edited

Pull Request Template

What are you trying to address

Description of new changes

  • Add Visio and Powerpoint option
  • Restructure the page so that the three options are described (Visio, PowerPoint, Drawio)

For all pull requests

  • Link to the issue you are solving (so it gets closed)
  • Label the pull request with the appropriate area(s)
  • Assign potential reviewers (you may also want to contact them on Teams to ensure timely reviews)
  • Assign the project - Engineering Playbook Backlog
  • Assign the pull request to yourself

@benjguin benjguin marked this pull request as ready for review January 20, 2023 13:55
@TessFerrandez TessFerrandez added the design reviews Design reviews topic label Jan 20, 2023
TessFerrandez
TessFerrandez approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@TessFerrandez TessFerrandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,

Approving with a suggestion

docs/design/design-reviews/recipes/preferred-diagram-tooling.md Outdated Show resolved Hide resolved
shiranr
shiranr approved these changes Jan 22, 2023
View reviewed changes
Copy link
Contributor

@shiranr shiranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a small NIT comment :)

@shiranr shiranr merged commit 1221e13 into microsoft:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiranr shiranr shiranr approved these changes

@TessFerrandez TessFerrandez TessFerrandez approved these changes

@tompaana tompaana Awaiting requested review from tompaana

Assignees

@benjguin benjguin

Labels
design reviews Design reviews topic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update diagram tooling to include Visio or PowerPoint
3 participants
@benjguin @shiranr @TessFerrandez