We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audioContext.audioWorklet
In PCMRecorder.ts, no matter if audioContext.audioWorklet is supported by the browser/environment, it will create audio worklet as blob URL.
PCMRecorder.ts
I think the better logic should be:
if (!!context.audioWorklet) { if (!this.privSpeechProcessorScript) { ... this.privSpeechProcessorScript = URL.createObjectURL(blob); } context.audioWorklet .addModule(this.privSpeechProcessorScript) ... }
This will help when the SDK is run under JSDOM, such as Jest. This is because JSDOM does not support URL.createObjectURL.
URL.createObjectURL
The text was updated successfully, but these errors were encountered:
@compulim Thanks for writing this up, and using JS Speech SDK. If you create a PR, I'll test the change.
Sorry, something went wrong.
glharper
Successfully merging a pull request may close this issue.
In
PCMRecorder.ts
, no matter ifaudioContext.audioWorklet
is supported by the browser/environment, it will create audio worklet as blob URL.I think the better logic should be:
This will help when the SDK is run under JSDOM, such as Jest. This is because JSDOM does not support
URL.createObjectURL
.The text was updated successfully, but these errors were encountered: