Fmegen/supporting from endpoint with token #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouwangzw
reviewed
Feb 19, 2019
| * Note: Please use your LanguageUnderstanding subscription key in case you want to use the Intent recognizer. | ||
| * Note: The query parameters specified in the endpoint URL are not changed, even if they are set by any other APIs. |
There was a problem hiding this comment.
nope, updated the docs for now. #Closed
zhouwangzw
reviewed
Feb 19, 2019
zhouwangzw
reviewed
Feb 19, 2019
| console.info("Skipping test."); | ||
| done(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
this added test is not running in Azure DevOps? #WontFix
There was a problem hiding this comment.
i hope it is part of the end-2-end testing since it takes >10minutes #WontFix
There was a problem hiding this comment.
@mahilleb-msft is there a way to specify this in the pullrequest? #WontFix
wolfma61
reviewed
Feb 19, 2019
| // make a connection to the standard speech endpoint. | ||
| const endpointString: string = "wss://" + Settings.SpeechRegion + ".stt.speech.microsoft.com"; | ||
|
|
||
| const s: sdk.SpeechConfig = sdk.SpeechConfig.fromEndpoint(new URL(endpointString), Settings.SpeechRegion); |
There was a problem hiding this comment.
gets the endpoint and the region? #Closed
zhouwangzw
reviewed
Feb 19, 2019
| // make a connection to the standard speech endpoint. | ||
| const endpointString: string = "wss://" + Settings.SpeechRegion + ".stt.speech.microsoft.com"; | ||
|
|
||
| const s: sdk.SpeechConfig = sdk.SpeechConfig.fromEndpoint(new URL(endpointString), Settings.SpeechRegion); |
There was a problem hiding this comment.
As Wolfgang pointed out, region seems be wrong? Did the test pass? #Closed
zhouwangzw
reviewed
Feb 19, 2019
| @@ -208,3 +208,179 @@ test("AuthToken refresh works correctly", (done: jest.DoneCallback) => { | |||
| }); | |||
| }); | |||
| }, 1000 * 60 * 25); // 25 minutes. | |||
|
|
|||
| test("AuthToken refresh works even with fromEndpoint configurations", (done: jest.DoneCallback) => { | |||
There was a problem hiding this comment.
Does it test emty subscription key with fromEndpoint? #Closed
zhouwangzw
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.