Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove set_abi from AbiTransferable #230

Merged
merged 3 commits into from Nov 5, 2021

Conversation

sivadeilra
Copy link
Contributor

The set_abi trait method is defined, but never used. I'm guessing this is a leftover from some previous design.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I'm trying to remember what the purpose of set_abi originally was for. It seems that it was never used in com-rs having been borrowed from winrt-rs (now windows-rs). The mechanism is usually reserved for out params. I guess we're just requiring the user to write "raw" out params (e.g., *mut T) but if we want to add some convenience functionality to not have to write raw pointers, we could do that... However, the trend for this crate is to keep it simply and as close to raw as possible, so perhaps we just leave it as is.

@rylev rylev merged commit 763e7d9 into microsoft:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants