Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RustCLI processing to handle virtual manifests / skip over vendor packages #1015

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

FernandoRojo
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 23, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 75.3%. Comparing base (c2cfd4d) to head (6074a78).

Files Patch % Lines
...mponentDetection.Detectors/rust/RustCliDetector.cs 76.9% 4 Missing and 5 partials ⚠️
...etection.Detectors/rust/Contracts/CargoMetadata.cs 0.0% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1015   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files        236     236           
  Lines      10353   10374   +21     
  Branches    1025    1032    +7     
=====================================
+ Hits        7800    7817   +17     
+ Misses      2269    2267    -2     
- Partials     284     290    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FernandoRojo FernandoRojo merged commit 0b8a2e6 into main Feb 24, 2024
22 of 26 checks passed
@FernandoRojo FernandoRojo deleted the ferojo/rustCLIvalidationFixes branch February 24, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants