Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip prod switch for rust detector and clean up root dependencies #1034

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

FernandoRojo
Copy link
Contributor

No description provided.

@FernandoRojo FernandoRojo requested a review from a team as a code owner March 15, 2024 03:50
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.6%. Comparing base (fb464ca) to head (4d4d46f).
Report is 8 commits behind head on main.

Files Patch % Lines
...mponentDetection.Detectors/rust/RustCliDetector.cs 66.6% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1034     +/-   ##
=======================================
+ Coverage   75.4%   75.6%   +0.1%     
=======================================
  Files        236     236             
  Lines      10412   10492     +80     
  Branches    1041    1068     +27     
=======================================
+ Hits        7855    7933     +78     
- Misses      2267    2269      +2     
  Partials     290     290             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya cobya added version:minor type:feature Feature (new functionality) detector:rust The Rust Cargo detector labels Mar 15, 2024
Copy link

github-actions bot commented Mar 19, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@FernandoRojo FernandoRojo merged commit c549433 into main Mar 19, 2024
22 of 26 checks passed
@FernandoRojo FernandoRojo deleted the users/ferojo/prodRust branch March 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:rust The Rust Cargo detector type:feature Feature (new functionality) version:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants