Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a random name for working folder for IvyDetector #1101

Merged
merged 1 commit into from
May 13, 2024

Conversation

abyss638
Copy link
Member

@abyss638 abyss638 commented May 8, 2024

IvyDetector creates files in a folder named "ComponentDetection_Ivy" in the temporary folder.
However if multiple detectors run in parallel, it brings a race condition when detectors manipulate files in the same folder.

Solution: Use random name for IvyDetector working folder.

… multiple detectors are running in parallel.
@abyss638 abyss638 requested a review from a team as a code owner May 8, 2024 14:39
@abyss638 abyss638 requested a review from grvillic May 8, 2024 14:39
@cobya cobya added type:bug Bug fix of existing functionality detector:ivy The Ivy detector labels May 13, 2024
Copy link
Contributor

@cobya cobya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! If this doesn't fix the issue you're hitting, feel free to open a new PR 👍

@cobya cobya merged commit 551850f into microsoft:main May 13, 2024
21 checks passed
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:ivy The Ivy detector type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants