Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration component detection to .net6 #288

Merged
merged 31 commits into from
Oct 6, 2022
Merged

Migration component detection to .net6 #288

merged 31 commits into from
Oct 6, 2022

Conversation

RushabhBhansali
Copy link
Contributor

@RushabhBhansali RushabhBhansali commented Oct 6, 2022

Created based on #76

Changes from #76

  • upgraded CD build to .net6

Additional work (only in this PR):

  • Fixed compilation errors and suppressed the analyzer errors

Testing

  • successful dotnet build.
  • successful unit tests.

.editorconfig Outdated Show resolved Hide resolved
global.json Outdated Show resolved Hide resolved
@JamieMagee JamieMagee added version:major type:refactor Refactoring or improving of existing code breaking change Breaking change, requires major version bump and removed type:refactor Refactoring or improving of existing code labels Oct 6, 2022
@JamieMagee JamieMagee added the type:ci Build or repository configuration label Oct 6, 2022
@JamieMagee
Copy link
Member

Closes #107

@JamieMagee JamieMagee mentioned this pull request Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

.editorconfig Outdated Show resolved Hide resolved
@JamieMagee JamieMagee merged commit f246185 into main Oct 6, 2022
@JamieMagee JamieMagee deleted the net6-migration-2 branch October 6, 2022 22:38
@JamieMagee JamieMagee mentioned this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking change, requires major version bump type:ci Build or repository configuration version:major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants