chore: bump container image to .NET 6 #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After #107 and #162 we've migrated the target framework, and related dependencies, to .NET 6. However, the container image at the root of the repository was missed. This PR: - changes the base images to their `6.0-cbl-mariner2.0` tags - Removes `gradle` from the final image (It doesn't appear to be available for Mariner 2.0) - Removes trimming (Component Detection is incompatible with trimming due to our use of reflection) - Makes a small linting fix in `DetectorProcessingService.cs` (IDE0055)
JamieMagee
requested review from
jcfiorenzano,
grvillic and
RushabhBhansali
and removed request for
jcfiorenzano
jcfiorenzano
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #107 and #162 we've migrated the target framework, and related dependencies, to .NET 6. However, the container image at the root of the repository was missed.
This PR:
6.0-cbl-mariner2.0tagsgradlefrom the final image (It doesn't appear to be available for Mariner 2.0)DetectorProcessingService.cs(IDE0055)