Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No instruction to sign .NET Foundation CLA #143

Open
AptiviCEO opened this issue Aug 20, 2023 · 7 comments
Open

No instruction to sign .NET Foundation CLA #143

AptiviCEO opened this issue Aug 20, 2023 · 7 comments

Comments

@AptiviCEO
Copy link

I made my first contribution to a project which is supported by .NET Foundation: https://github.com/nunit/docfx-action. This is my first contribution: nunit/docfx-action#32. However, when I checked the pull request status, I saw that it said:

Contributor License Agreement is not agreed yet.
This check verifies that the author has agreed to a CLA with Microsoft.

I searched Google on how to sign a CLA, but I found nothing, so it looks impossible to sign a CLA. Can anybody point me to how to sign a CLA?

@DragosDanielBoia
Copy link
Member

DragosDanielBoia commented Sep 11, 2023

@AptiviCEO @pkgw a comment on the PR should have been generated to explain what you need to do. Can you please try to push a small change to the PR and see if tje comment is showing up?

@pkgw
Copy link

pkgw commented Sep 11, 2023

@DragosDanielBoia The PR in question has already been merged, so I don't think I can do that now, but I'll keep an eye out the next time we have one from a new contributor.

@AptiviCEO
Copy link
Author

@DragosDanielBoia I pushed a commit to the fork in question, and even edited the PR title and description, but there is still no comment from the CLA bot.

The PR is not merged and is still waiting for the CLA comment.

Tried commenting "@microsoft-github-policy-service agree", but no change.

@JohannesLampel
Copy link
Contributor

Since this is a dotnet owned repo, the comment should be @dotnet-policy-service agree.

@jeffwilcox
Copy link

@ChrisSfanos anything you think we should change in the docs or point to on the .NET specific points before closing this?

@AptiviCEO
Copy link
Author

@JohannesLampel @dotnet-policy-service agree worked! Thanks!

Proof: https://github.com/nunit/docfx-action/pull/32/checks?check_run_id=17148830822

@ChrisSfanos
Copy link
Member

I don't know if we really have any content that is .NET foundation specific (I've had more than one comment where someone tried the microsoft CLA agree vs the dotnet agree. I'm open to updating/adding content to the README that calls out the dotnet CLA if we think that's a good spot for it - thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants