Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .NET SDK to 7.0 #32

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Updated .NET SDK to 7.0 #32

merged 7 commits into from
Oct 14, 2023

Conversation

AptiviCEO
Copy link

@AptiviCEO AptiviCEO commented Aug 20, 2023

This pull request will allow docfx-action to use the .NET 7.0 SDK to be able to build applications that are built with .NET 7.0.

Also, this PR updates DocFX to 2.70.3

Tested with Nitrocid KS and got the following results:

Thanks!

@AptiviCEO AptiviCEO changed the title Updated .NET SDK to 7.0 Updated .NET SDK to 7.0 and DocFX to 2.70.3 Sep 11, 2023
@bfren
Copy link

bfren commented Sep 22, 2023

This would be super handy if it could be merged into a release soon?

@AptiviCEO
Copy link
Author

@dotnet-policy-service agree

@AptiviCEO AptiviCEO changed the title Updated .NET SDK to 7.0 and DocFX to 2.70.3 Updated .NET SDK to 7.0 and DocFX to 2.70.4 Sep 26, 2023
@SeanKilleen
Copy link
Member

Sorry @AptiviCEO / @bfren! Thanks for your patience. My brother got married and I think I totally missed this PR at the time. I'll get it merged in.

@SeanKilleen SeanKilleen changed the title Updated .NET SDK to 7.0 and DocFX to 2.70.4 Updated .NET SDK to 7.0 Oct 14, 2023
Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and then should be good.

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SeanKilleen SeanKilleen enabled auto-merge (squash) October 14, 2023 20:04
@SeanKilleen SeanKilleen merged commit 0193b5c into nunit:master Oct 14, 2023
3 checks passed
@AptiviCEO
Copy link
Author

You are welcome, and thanks for approving the changes @SeanKilleen. I'll tell you when .NET 8 releases.

@SeanKilleen
Copy link
Member

Oh I'm clued into the release date. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants