Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Build instead of Prepare #92

Closed
dylanvdmerwe opened this issue Apr 1, 2016 · 5 comments
Closed

Build instead of Prepare #92

dylanvdmerwe opened this issue Apr 1, 2016 · 5 comments

Comments

@dylanvdmerwe
Copy link

Normally cordova prepare would be enough however, for example, Ionic 2 requires a compilation step to compile (using gulp) TypeScript and SCSS to create the www directory.

When using the code-push release-cordova command it runs cordova prepare for you, however with Ionic 2 no new changes would be compiled into the platform's www directory.

Maybe think about running a complete cordova build step in order to ensure all scripts and everything is ready for the appropriate platform for the release-cordova command?

@geof90
Copy link
Contributor

geof90 commented Apr 1, 2016

That makes sense. I guess one way we could get it to work could be a CLI flag eg. code-push release-cordova --build, if --build is provided, it runs cordova build instead of cordova prepare?

@dylanvdmerwe
Copy link
Author

Sounds good to me!

@lostintangent
Copy link
Member

So does Ionic 2 add before/after build hooks to Cordova which trigger your Gulp scripts? If so, it definitely seems like a great solution for us to allow triggering cordova build instead of cordova prepare in the release-cordova command.

@dylanvdmerwe
Copy link
Author

Yes, ionic 2 only triggers an update of the platform's www folder on build not prepare.

@lostintangent
Copy link
Member

OK cool, we'll take care of this change this week. Apologies for the inconvenience!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants