Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App is not simulated when <head> contains any data-* attribute #128

Closed
albertinad opened this issue Aug 9, 2016 · 1 comment · Fixed by #129
Closed

App is not simulated when <head> contains any data-* attribute #128

albertinad opened this issue Aug 9, 2016 · 1 comment · Fixed by #129
Assignees
@albertinad
Labels
bug priority-high

Comments

@albertinad
Copy link
Collaborator

albertinad commented Aug 9, 2016 •
edited

When adding data-* attributes to element from the index.html, simulation files are not injected, so cordova loose the simulated native bridge and enter in an infinite loop of processing messages.

screen shot 2016-08-09 at 2 18 02 pm

screen shot 2016-08-09 at 2 18 27 pm
@albertinad albertinad self-assigned this Aug 9, 2016
@albertinad
Copy link
Collaborator Author

This issue is reported by Intel XDK users.

@albertinad albertinad mentioned this issue Aug 9, 2016
Merged
albertinad added a commit that referenced this issue Aug 9, 2016
@albertinad
Updating sim hosts file injection while streaming app host. (#129)
9c002cc 
- Update regex to support matching head with content like data-*
attributes
- Using captures for inserting the new head: do not replace it
with a new one, take the current head and add the script files
Fix for #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albertinad albertinad

Labels
bug priority-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating sim hosts file injection while streaming app host. microsoft/cordova-simulate
1 participant
@albertinad