[Work in Progress] Enable CMake build on Windows #1011
Conversation
lalitb
requested review from
kindbe,
maxgolov,
mkoscumb,
reyang,
bliptec and
sid-dahiya
as code owners
| @@ -295,7 +322,7 @@ endif() | |||
| # Packaging | |||
| ################################################################################################ | |||
|
|
|||
| if (BUILD_PACKAGE) | |||
| if (BUILD_PACKAGE AND (NOT WIN32)) | |||
There was a problem hiding this comment.
minor nit: what is the reason to check for NOT WIN32 - was it failing something if you don't add it? I wonder if we could eventually add logic in here under the if (BUILD_PACKAGE) to produce a package, e.g. nuget or alike, even if we build on Windows. My selfish interest - is we'd likely need this CMake flow for our organization telemetry.
|
|
| ${CMAKE_CURRENT_SOURCE_DIR}/../third_party/googletest/googletest/include | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../third_party/googletest/googlemock/include | ||
| ) | ||
| message("-->Lalit tests") |
|
|
||
| PS C:\cpp_client_telemetry\build> cmake --build . | ||
|
|
||
| This should build the 1DS C++ library, along with the functional and unit tests in `build` folder |
There was a problem hiding this comment.
Should we add instructions on how to add it to another projects CMake as well? Like add_directory(<path to cpp_client_telemetry>)?
Work in progress.