Cleanup redundant inline specifiers #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the fix for #255, I tried adding
inlineto any function or method that was defined in a header. However, that's not what ultimately fixed it, as far as I can tell. I think moving the template methods of theModified...template structs to an anonymous namespace is what deduplicated their symbols and let-flto=autowork again in GCC 12.I've tested with and without this in GCC 12 and it looks like it does not change the size of the binary or the benchmark speed. It's just removing some redundant and potentially misleading
inlinespecifiers, since it's implied anytime a method is defined in the body of the class/struct declaration, and it's impossible for any of the type-erased wrappers to call a virtual method on theModel<T>type as an inline method because the whole point of type erasure is that it doesn't know the concrete type.