Reflect PEGTL api change .content() -> .string()/.string_view() #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PEGTL commit: 7b9d65ded23fe3ccc7ca645f3af73bfe60ae725c Signed-off-by: Marc Bodmer <marc.bodmer@securiton.ch>
|
|
|
Ah, I should mention in the README that I'm trying to maintain C++11 compatibility, so I'm using the 2.7.x branch of PEGTL rather than master. I've been thinking about adopting some of the newer standards in a new major version (much like PEGTL itself), in which case this is definitely required to stay in synch with PEGTL. There are probably a lot of other spots where I could be taking advantage of |
wravery
added a commit
that referenced
this pull request
Mar 6, 2019
Per PR #43, I need to describe the C++11 compatibility goal. Later I will likely drop that requirement in a new branch to take advantage of newer features in C++14 and C++17.
|
Thanks for the PR, I ended up merging it manually in the 3.0 branch and it no longer applies to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PEGTL commit: 7b9d65ded23fe3ccc7ca645f3af73bfe60ae725c
taocpp/PEGTL@7b9d65d