Zoom to error bar range

[sharlagelfand]

Expanding on #44, would be good to have the final frame zoom in to only show the range of the error bars, not of the full data.

I'll generate a test spec for this.

[sharlagelfand]

@giorgi-ghviniashvili here is a sample spec, and how it looks now:

zoomed_summary.mov

The zoom kind of works, but since the axis is shared between the last few frames it doesn't update with the new range.

[giorgi-ghviniashvili]

@sharlagelfand Seems like this is gemini issue that it does not update axis. Let me take a look why.

[giorgi-ghviniashvili]

OK, fixed it. It was not correctly drawing vega-axis layer.

y-axis-fix.mov

[sharlagelfand]

Thanks @giorgi-ghviniashvili! This looks great. I tried it with error bars as well but it looks like they're drawn twice or something, could you take a look? Here are the specs.

double_errorbar.mov

[giorgi-ghviniashvili]

@sharlagelfand sorry, forgot to clear old container, here it is:

error-bars.mov

[sharlagelfand]

Thanks, looks good!!

[sharlagelfand]

Going to reopen this since it looks like there's an issue with zooming on errorbars when there are no facets, as in this spec:

no_facets_errorbar_off_on_zoom.mov

[giorgi-ghviniashvili]

Sad.. It is gemini thing, not able to correctly update y axis.. Trying to figure it out, whether it is a gemini bug or ours.

[giorgi-ghviniashvili]

@sharlagelfand, so the reason of the issue is because we have different y-axis on last two specs.

Ok, I fixed it and now it correctly updates y-axis when animating last frame.

---

Ok, thats good. Now bad news, it does not correctly change width (to shift x-axis because of floating points) and still getting this:

Gemini recommend does same in gemini-editor, it just expands axis to the left:

---

I tried to add this to gemini spec manually in code after recommend

{
    "component": "view",
    "change": {
      "signal": [
        "width", "height"
      ]
    },
    "timing": {
          "duration": {
              "ratio": 1
          }
      }
  }

and seems like it worked:

zoom-error-bars-fix.mov

[sharlagelfand]

It looks good to me now, thanks @giorgi-ghviniashvili!

Just curious, do you know why the sizing of axes changes and overlaps in Firefox, but not in Chrome? Everything looks pretty nice in Chrome:

chrome.mov

But a bit rough in Firefox (my main browser):

firefoxc.mov

[giorgi-ghviniashvili]

No Idea, will try to debug and see why.