-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation of dbt-synapse in same env as dbt-sqlserver conflicts namespace and starts running SQL server models using synapse Adapter #18
Comments
This could be fixed with isolated envs, but I think that you should be able to use different adapaters separated using the project.yml |
great point. It's definitely a use case we'd like to support wherein we could have a dev target be Azure SQL and a production target be Synapse. I've been meaning to rename the target officially to
I guess we won't know until we try! |
That's annoying!
Is it possible to resolve this using classes?
I.e. could there be a Microsoft class that sqlserver and synapse both
inherit from or similar?
…On Wed, 30 Sep 2020, 07:28 Anders, ***@***.***> wrote:
great point. It's definitely a use case we'd like to support wherein we
could have a dev target be Azure SQL and a production target be Synapse.
I've been meaning to rename the target officially to synapse in our code
with #6 <#6>, but have been
uncertain of what that means when we need to pull an update from the
upstream dbt-sqlserver will it:
1. respect our rename, or
2. will we have to do a merge commit where we rename the macro names
every time back to synapse?
I guess we won't know until we try!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACVRBJMOY7LDOFZ4PMFM5Y3SILFYFANCNFSM4R53B2NQ>
.
|
Yeah that's an option I think. Check out this dbt slack thread from a month ago where some options are discussed. |
I guess it's fairly edge case for many users and easily solvable using venvs, so a nice to have feature change really. |
Going to do some experiments this week on this. |
One option: you can have That would enable you to avoid repeating boilerplate code around connections, for instance, between this repo and macrosRight now, both Currently, |
@jtcohen6 this is definitely something I've been wanting to discuss. Take a look at dbt-msft/dbt-sqlserver#32. Looking at just the the Another possible alternative is to have a single adapter,
The high level differences are:
from the
|
Id | EngineEdition |
---|---|
1 | Personal or Desktop Engine (Not available in SQL Server 2005 (9.x) and later versions.) |
2 | Standard (This is returned for Standard, Web, and Business Intelligence.) |
3 | Enterprise (This is returned for Evaluation, Developer, and Enterprise editions.) |
4 | Express (This is returned for Express, Express with Tools, and Express with Advanced Services) |
5 | SQL Database |
6 | Microsoft Azure Synapse Analytics (formerly SQL Data Warehouse) |
8 | Azure SQL Managed Instance |
9 | Azure SQL Edge (This is returned for all editions of Azure SQL Edge) |
This sounds like a great way of solving it. It would make it more transparent what the differences are as well. |
getting very close to this with #32! |
resolved! |
Due to the presence of two identical 'types' in the adapters.
On my side dbt defaults to using the synapse connection, I'm not sure why.
I suspect that this would be fixed with an updated type: SqlServerSynapse but I'd have to read and understand the code better to be sure.
Actual error:
('42000', "[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near 'DISTRIBUTION'. (102) (SQLExecDirectW)")
The text was updated successfully, but these errors were encountered: