[backport] 1.7 #230 [bug] disable --limit on show (again)
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[bug] disable `--limit` on `show` (again)
dataders
force-pushed
the
backport_235_to_1.7.latest
branch
from
516f309
to
ec158e0
Compare
prdpsvs
reviewed
Apr 15, 2024
| {%- set warn = "-- limit of " ~ limit ~ " is ignored. Synapse doesn't support the implementation" -%} | ||
|
|
||
| {{ warn }} | ||
| {{ sql }} |
There was a problem hiding this comment.
@dataders , I just realized that the sql will select entire data in the table. What's the downside of leaving the query as
select top {{ limit }} * from ( {{ sql }} ) as model_limit_subq
There was a problem hiding this comment.
check out #228 basically comes down to lack of support for nested CTEs again! sql can't contain a WITH or it breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #230