Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add az cli auth #35

Closed
wants to merge 23 commits into from
Closed

Conversation

JCZuurmond
Copy link
Contributor

This PR add the option to use the authentication of the Azure CLI.

@JCZuurmond
Copy link
Contributor Author

How do we improve testing here?

@JCZuurmond
Copy link
Contributor Author

I think it would be neat to do something similar as they do here.

Looking at what is supported, we could add:

  • AzureCliCredential (as done in this PR)
  • CertificateCredential : allowing to have a certificate path instead off the secret.
  • EnvironmentCredential : using environment variables.
  • InteractiveBrowserCredential: login with browser.
  • ManagedIdentityCredential: managed identity
  • UsernamePasswordCredential: user-name password
  • VisualStudioCodeCredential: visual studio code user.

Except for the ActiveDirectory Integrated (Windows only) it would cover all the currently supported login methods and more.

@dataders
Copy link
Collaborator

This is incredible, thanks! @NandanHegde15 and I were just talking about how
ActiveDirectoryIntegrated wasn't going to work because it requires Active Directory Federation Services which is not ideal IMHO.

@JCZuurmond
Copy link
Contributor Author

Great, I can add the other authentication methods in separate PRs. I think we should do all authentications via azure.identity.

@dataders
Copy link
Collaborator

@JCZuurmond can you open this on https://github.com/mikaelene/dbt-sqlserver ? In #32 we're working on having dbt-synapse just inherit the connection class methods from dbt-sqlserver. In this way, one will also be able to use the Azure CLI to auth to Azure SQL

@dataders dataders closed this Dec 27, 2020
JCZuurmond added a commit to JCZuurmond/dbt-sqlserver that referenced this pull request Dec 29, 2020
See [this closed PR](microsoft/dbt-synapse#35)
for the full commit history
@JCZuurmond
Copy link
Contributor Author

Done here

JCZuurmond added a commit to JCZuurmond/dbt-sqlserver that referenced this pull request Jan 6, 2021
See [this closed PR](microsoft/dbt-synapse#35)
for the full commit history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants