Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config and core arguments API docstrings #31

Closed
ShadenSmith opened this issue Feb 6, 2020 · 0 comments · Fixed by #32
Closed

Config and core arguments API docstrings #31

ShadenSmith opened this issue Feb 6, 2020 · 0 comments · Fixed by #32
Assignees
@tjruwase
Labels
documentation Improvements or additions to documentation

Comments

@ShadenSmith
Copy link
Contributor

The documentation for add_core_arguments() and add_config_arguments() could be expanded... Can we document what arguments are added in the docstrings? (these things could be unit tested too)
@ShadenSmith ShadenSmith added the documentation Improvements or additions to documentation label Feb 6, 2020
@tjruwase tjruwase self-assigned this Feb 6, 2020
@tjruwase tjruwase linked a pull request Feb 6, 2020 that will close this issue
Improve doc string for add_XXX_arguments #32
Merged
@gongwei-130 gongwei-130 mentioned this issue Aug 7, 2020
Open
@GrvLeo GrvLeo mentioned this issue Oct 22, 2020
Closed
rraminen pushed a commit to rraminen/DeepSpeed that referenced this issue Apr 28, 2021
@jeffra @samyam
remove distributed requirement from model building (microsoft#31)
71ab29d 
* remove distributed requirement from model building, this is needed for mpi/aml support for this model

* Update modelingpreln.py

Removed the print. It would print tons of times after removing the rank check otherwise

Co-authored-by: Samyam Rajbhandari <samyamr@microsoft.com>
@garvct garvct mentioned this issue Jun 29, 2021
Open
rraminen pushed a commit to rraminen/DeepSpeed that referenced this issue Aug 18, 2021
@jithunnair-amd
Merge pull request microsoft#31 from rraminen/PR_enable_megatron_tests
1d156bc 
Enabled few test_configurable_parallel tests which work on ROCm
liamcli pushed a commit to determined-ai/DeepSpeed that referenced this issue Sep 27, 2021
@sdtblck
Bf16 (microsoft#31)
996951e 
* bf16 initial commit

* Update engine.py

* update split_half_float_double_csr dtypes

* update to bf16 communication (make flag optional)

* Update requirements-sparse_attn.txt

* add compressed bf16 allreduce

* add compressed bf16 allreduce

* Update __init__.py

* Update engine.py

* Update __init__.py

* Update engine.py

* zero1 + bf16

* zero 2 + bf16

* pipe parallel + bf16

* pipe parallel + bf16

* partition activations + bf16
delock referenced this issue in delock/DeepSpeedSYCLSupport Sep 21, 2022
@delock @inkcherry
[test] fix unit test (#31)
ec9c7a3
@lambda7xx lambda7xx mentioned this issue Feb 24, 2023
Closed
@phalexo phalexo mentioned this issue Oct 11, 2023
Open
baodii pushed a commit to baodii/DeepSpeed that referenced this issue Nov 23, 2023
@Yejing-Lai
fix imbalance autotp issue (microsoft#31)
09a348c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjruwase tjruwase

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve doc string for add_XXX_arguments microsoft/DeepSpeed
2 participants
@ShadenSmith @tjruwase