Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Enhancement: Adding transport trait #1088

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Dec 15, 2023

This PR adds a transport trait for high level network transport. In contrast to our network runtime, which abstracts the lowest level network API (i.e., only raw ethernet send and receive), the NetworkTransport trait abstracts a high-level network API including sockets. There are 3 commits that do the following:

  1. Add a transport generic to the CatnapQueue
  2. Add a transport generic to the CatnapLibOS
  3. Move the CatnapLibOS and CatnapQueue to a common NetworkLibOS and NetworkQueue in the demikernel/libos/network directory and remove all CatnapLibOS and CatnapQueue code.

@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Dec 18, 2023
@ppenna ppenna assigned ppenna and iyzhang and unassigned ppenna Dec 18, 2023
@iyzhang iyzhang force-pushed the enhancement-runtime-add-transport-trait branch from cd674d1 to 1337d38 Compare December 18, 2023 18:46
@anandbonde anandbonde self-requested a review December 18, 2023 19:52
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ppenna ppenna force-pushed the enhancement-runtime-add-transport-trait branch from 54b5885 to 61d0ebf Compare December 19, 2023 13:35
@ppenna ppenna merged commit 549d5e9 into dev Dec 19, 2023
15 checks passed
@ppenna ppenna deleted the enhancement-runtime-add-transport-trait branch December 19, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants