Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inetstack] Wait ACK on Push #1103

Merged
merged 4 commits into from
Dec 20, 2023
Merged

[inetstack] Wait ACK on Push #1103

merged 4 commits into from
Dec 20, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Dec 20, 2023

Description

This PR closes #363.

Summary of Changes

  • Drop deprecated unit-tests in favor of simulation tests
  • Introduces an async queue to block push operations until the remote peer ACKs sent data.

@ppenna ppenna added the bug Something Isn't Working label Dec 20, 2023
@ppenna ppenna self-assigned this Dec 20, 2023
iyzhang
iyzhang reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

src/rust/inetstack/protocols/tcp/passive_open.rs Outdated Show resolved Hide resolved
src/rust/inetstack/protocols/tcp/passive_open.rs Show resolved Hide resolved
src/rust/inetstack/protocols/tcp/passive_open.rs Outdated Show resolved Hide resolved
src/rust/inetstack/protocols/tcp/queue.rs Outdated Show resolved Hide resolved
@ppenna ppenna force-pushed the bugfix-inetstack-wait-ack-on-push branch from 0b972eb to 571ffef Compare December 20, 2023 18:13
@ppenna ppenna merged commit 40fce94 into dev Dec 20, 2023
15 checks passed
@ppenna ppenna deleted the bugfix-inetstack-wait-ack-on-push branch December 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[inetstack] Waiting for a Send Buffer to be Reusable Doesn't Work
2 participants
@ppenna @iyzhang