Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Workaround: Adjust TIMER resolutions to fix perf regression #1285

Merged
merged 1 commit into from
May 16, 2024

Conversation

anandbonde
Copy link
Contributor

@anandbonde anandbonde commented May 16, 2024

Bing observed performance regression between Demikernel builds. The TIMER resolution changes that were introduced between the build were the root cause. So, tuning these values manually to work around this issue for now.

@anandbonde anandbonde requested a review from iyzhang May 16, 2024 18:01
@ppenna ppenna self-requested a review May 16, 2024 18:03
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Processing commits from 7f8103a to c082e0a (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 6139.54
1 4228 2b949e3 6108.88
2 4234 cd2a133 6068.32
3 4236 3dee402 5697.58
4 4238 540c178 5258.1
5 4241 fc96ac0 5206.82
6 4244 b7ee223 5125.77
7 4247 dca2919 7239.47
8 4254 c25fdd5 6025.63
9 4258 0fcdcdc 5994.38
10 4265 e3f3442 5924.24
11 4267 4b1ed79 5436.41
12 4270 ffaf885 5102.93
13 4272 c420595 6149.59
14 4274 71a0b41 5897.01

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 458.145
1 4228 2b949e3 430.218
2 4234 cd2a133 433.72
3 4236 3dee402 476.449
4 4238 540c178 440.223
5 4241 fc96ac0 433.896
6 4244 b7ee223 460.887
7 4247 dca2919 570.242
8 4254 c25fdd5 502.417
9 4258 0fcdcdc 441.102
10 4265 e3f3442 437.991
11 4267 4b1ed79 437.951
12 4270 ffaf885 437.099
13 4272 c420595 435.595
14 4274 71a0b41 426.753

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 6365.38
1 4228 2b949e3 10184.6
2 4234 cd2a133 6353.37
3 4236 3dee402 6178.99
4 4238 540c178 5592.41
5 4241 fc96ac0 5860.03
6 4244 b7ee223 6849.73
7 4247 dca2919 6351.2
8 4254 c25fdd5 6326.4
9 4258 0fcdcdc 6345.47
10 4265 e3f3442 6373.19
11 4267 4b1ed79 5891.16
12 4270 ffaf885 5649.32
13 4272 c420595 6361.22
14 4274 71a0b41 6295.41

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 433.13
1 4228 2b949e3 643.435
2 4234 cd2a133 418.845
3 4236 3dee402 433.43
4 4238 540c178 422.624
5 4241 fc96ac0 418.76
6 4244 b7ee223 573.35
7 4247 dca2919 435.835
8 4254 c25fdd5 438.997
9 4258 0fcdcdc 430.333
10 4265 e3f3442 451.595
11 4267 4b1ed79 430.163
12 4270 ffaf885 426.183
13 4272 c420595 456.317
14 4274 71a0b41 449.419

Copy link

Processing commits from 7f8103a to c082e0a (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 1884.28
1 4228 2b949e3 1940.76
2 4234 cd2a133 1894.4
3 4236 3dee402 3389.54
4 4238 540c178 2034.87
5 4241 fc96ac0 1902.97
6 4244 b7ee223 2101.48
7 4247 dca2919 2106.76
8 4254 c25fdd5 2003.26
9 4258 0fcdcdc 1952.29
10 4265 e3f3442 1931.03
11 4267 4b1ed79 1949.47
12 4270 ffaf885 1894.84
13 4272 c420595 2012.8
14 4274 71a0b41 2082.83

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 493.454
1 4228 2b949e3 480.252
2 4234 cd2a133 431.12
3 4236 3dee402 937.122
4 4238 540c178 407.989
5 4241 fc96ac0 415.521
6 4244 b7ee223 394.332
7 4247 dca2919 407.457
8 4254 c25fdd5 426.626
9 4258 0fcdcdc 407.535
10 4265 e3f3442 396.753
11 4267 4b1ed79 395.685
12 4270 ffaf885 407.071
13 4272 c420595 415.161
14 4274 71a0b41 423.526

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 2524.44
1 4228 2b949e3 2357.02
2 4234 cd2a133 2234.82
3 4236 3dee402 2195.04
4 4238 540c178 1735.34
5 4241 fc96ac0 1696.62
6 4244 b7ee223 1758.94
7 4247 dca2919 1795.06
8 4254 c25fdd5 1729.9
9 4258 0fcdcdc 1714.5
10 4265 e3f3442 1788.16
11 4267 4b1ed79 1763.86
12 4270 ffaf885 1730.35
13 4272 c420595 1757.84
14 4274 71a0b41 1741.38

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 506.008
1 4228 2b949e3 469.568
2 4234 cd2a133 440.835
3 4236 3dee402 469.367
4 4238 540c178 386.665
5 4241 fc96ac0 387.502
6 4244 b7ee223 389.141
7 4247 dca2919 382.631
8 4254 c25fdd5 391.914
9 4258 0fcdcdc 390.17
10 4265 e3f3442 389.619
11 4267 4b1ed79 398.75
12 4270 ffaf885 395.653
13 4272 c420595 413.736
14 4274 71a0b41 416.024

Copy link

Processing commits from 7f8103a to c082e0a (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 458.344
1 4228 2b949e3 467.436
2 4234 cd2a133 513.478
3 4236 3dee402 442.857
4 4238 540c178 529.396
5 4241 fc96ac0 480.166
6 4244 b7ee223 507.442
7 4247 dca2919 489.056
8 4254 c25fdd5 476.425
9 4258 0fcdcdc 485.282
10 4265 e3f3442 450.464
11 4267 4b1ed79 516.944
12 4270 ffaf885 440.494
13 4272 c420595 447.518
14 4274 71a0b41 517.249
15 4275 c082e0a 2017.88

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 400.688
1 4228 2b949e3 418.063
2 4234 cd2a133 431.499
3 4236 3dee402 409.513
4 4238 540c178 823.94
5 4241 fc96ac0 392.997
6 4244 b7ee223 404.813
7 4247 dca2919 362.229
8 4254 c25fdd5 449.675
9 4258 0fcdcdc 423.344
10 4265 e3f3442 372.509
11 4267 4b1ed79 414.03
12 4270 ffaf885 388.025
13 4272 c420595 365.31
14 4274 71a0b41 571.701
15 4275 c082e0a 757.555

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 519.622
1 4228 2b949e3 501.764
2 4234 cd2a133 532.052
3 4236 3dee402 497.652
4 4238 540c178 472.631
5 4241 fc96ac0 498.244
6 4244 b7ee223 490.868
7 4247 dca2919 470.253
8 4254 c25fdd5 445.935
9 4258 0fcdcdc 477.221
10 4265 e3f3442 479.605
11 4267 4b1ed79 502.064
12 4270 ffaf885 476.914
13 4272 c420595 490.128
14 4274 71a0b41 464.041
15 4275 c082e0a 474.756

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 396.44
1 4228 2b949e3 413.111
2 4234 cd2a133 592.77
3 4236 3dee402 442.926
4 4238 540c178 384.613
5 4241 fc96ac0 397.613
6 4244 b7ee223 375.974
7 4247 dca2919 385.9
8 4254 c25fdd5 366.234
9 4258 0fcdcdc 379.738
10 4265 e3f3442 379.214
11 4267 4b1ed79 391.97
12 4270 ffaf885 373.839
13 4272 c420595 373.293
14 4274 71a0b41 387.314
15 4275 c082e0a 391.796

@anandbonde anandbonde force-pushed the workaround-ab-timer-resolution-manual-tuning branch from c082e0a to 13582fc Compare May 16, 2024 20:38
Copy link

Processing commits from 7f8103a to 13582fc (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 6139.54
1 4228 2b949e3 6108.88
2 4234 cd2a133 6068.32
3 4236 3dee402 5697.58
4 4238 540c178 5258.1
5 4241 fc96ac0 5206.82
6 4244 b7ee223 5125.77
7 4247 dca2919 7239.47
8 4254 c25fdd5 6025.63
9 4258 0fcdcdc 5994.38
10 4265 e3f3442 5924.24
11 4267 4b1ed79 5436.41
12 4270 ffaf885 5102.93
13 4272 c420595 6149.59
14 4274 71a0b41 5897.01

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 458.145
1 4228 2b949e3 430.218
2 4234 cd2a133 433.72
3 4236 3dee402 476.449
4 4238 540c178 440.223
5 4241 fc96ac0 433.896
6 4244 b7ee223 460.887
7 4247 dca2919 570.242
8 4254 c25fdd5 502.417
9 4258 0fcdcdc 441.102
10 4265 e3f3442 437.991
11 4267 4b1ed79 437.951
12 4270 ffaf885 437.099
13 4272 c420595 435.595
14 4274 71a0b41 426.753

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 6365.38
1 4228 2b949e3 10184.6
2 4234 cd2a133 6353.37
3 4236 3dee402 6178.99
4 4238 540c178 5592.41
5 4241 fc96ac0 5860.03
6 4244 b7ee223 6849.73
7 4247 dca2919 6351.2
8 4254 c25fdd5 6326.4
9 4258 0fcdcdc 6345.47
10 4265 e3f3442 6373.19
11 4267 4b1ed79 5891.16
12 4270 ffaf885 5649.32
13 4272 c420595 6361.22
14 4274 71a0b41 6295.41

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catpowder
0 4226 5b5bf06 433.13
1 4228 2b949e3 643.435
2 4234 cd2a133 418.845
3 4236 3dee402 433.43
4 4238 540c178 422.624
5 4241 fc96ac0 418.76
6 4244 b7ee223 573.35
7 4247 dca2919 435.835
8 4254 c25fdd5 438.997
9 4258 0fcdcdc 430.333
10 4265 e3f3442 451.595
11 4267 4b1ed79 430.163
12 4270 ffaf885 426.183
13 4272 c420595 456.317
14 4274 71a0b41 449.419

Copy link

Processing commits from 7f8103a to 13582fc (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 1884.28
1 4228 2b949e3 1940.76
2 4234 cd2a133 1894.4
3 4236 3dee402 3389.54
4 4238 540c178 2034.87
5 4241 fc96ac0 1902.97
6 4244 b7ee223 2101.48
7 4247 dca2919 2106.76
8 4254 c25fdd5 2003.26
9 4258 0fcdcdc 1952.29
10 4265 e3f3442 1931.03
11 4267 4b1ed79 1949.47
12 4270 ffaf885 1894.84
13 4272 c420595 2012.8
14 4274 71a0b41 2082.83
15 4277 13582fc 2018.23

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 493.454
1 4228 2b949e3 480.252
2 4234 cd2a133 431.12
3 4236 3dee402 937.122
4 4238 540c178 407.989
5 4241 fc96ac0 415.521
6 4244 b7ee223 394.332
7 4247 dca2919 407.457
8 4254 c25fdd5 426.626
9 4258 0fcdcdc 407.535
10 4265 e3f3442 396.753
11 4267 4b1ed79 395.685
12 4270 ffaf885 407.071
13 4272 c420595 415.161
14 4274 71a0b41 423.526
15 4277 13582fc 413.891

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 2524.44
1 4228 2b949e3 2357.02
2 4234 cd2a133 2234.82
3 4236 3dee402 2195.04
4 4238 540c178 1735.34
5 4241 fc96ac0 1696.62
6 4244 b7ee223 1758.94
7 4247 dca2919 1795.06
8 4254 c25fdd5 1729.9
9 4258 0fcdcdc 1714.5
10 4265 e3f3442 1788.16
11 4267 4b1ed79 1763.86
12 4270 ffaf885 1730.35
13 4272 c420595 1757.84
14 4274 71a0b41 1741.38
15 4277 13582fc 1804.56

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnip
0 4226 5b5bf06 506.008
1 4228 2b949e3 469.568
2 4234 cd2a133 440.835
3 4236 3dee402 469.367
4 4238 540c178 386.665
5 4241 fc96ac0 387.502
6 4244 b7ee223 389.141
7 4247 dca2919 382.631
8 4254 c25fdd5 391.914
9 4258 0fcdcdc 390.17
10 4265 e3f3442 389.619
11 4267 4b1ed79 398.75
12 4270 ffaf885 395.653
13 4272 c420595 413.736
14 4274 71a0b41 416.024
15 4277 13582fc 428.628

Copy link

Processing commits from 7f8103a to 13582fc (in the last 15 days)

Performance for Push() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 458.344
1 4228 2b949e3 467.436
2 4234 cd2a133 513.478
3 4236 3dee402 442.857
4 4238 540c178 529.396
5 4241 fc96ac0 480.166
6 4244 b7ee223 507.442
7 4247 dca2919 489.056
8 4254 c25fdd5 476.425
9 4258 0fcdcdc 485.282
10 4265 e3f3442 450.464
11 4267 4b1ed79 516.944
12 4270 ffaf885 440.494
13 4272 c420595 447.518
14 4274 71a0b41 517.249
15 4277 13582fc 438.602

Performance for Pop() in tcp-ping-pong-server

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 400.688
1 4228 2b949e3 418.063
2 4234 cd2a133 431.499
3 4236 3dee402 409.513
4 4238 540c178 823.94
5 4241 fc96ac0 392.997
6 4244 b7ee223 404.813
7 4247 dca2919 362.229
8 4254 c25fdd5 449.675
9 4258 0fcdcdc 423.344
10 4265 e3f3442 372.509
11 4267 4b1ed79 414.03
12 4270 ffaf885 388.025
13 4272 c420595 365.31
14 4274 71a0b41 571.701
15 4277 13582fc 393.133

Performance for Push() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 519.622
1 4228 2b949e3 501.764
2 4234 cd2a133 532.052
3 4236 3dee402 497.652
4 4238 540c178 472.631
5 4241 fc96ac0 498.244
6 4244 b7ee223 490.868
7 4247 dca2919 470.253
8 4254 c25fdd5 445.935
9 4258 0fcdcdc 477.221
10 4265 e3f3442 479.605
11 4267 4b1ed79 502.064
12 4270 ffaf885 476.914
13 4272 c420595 490.128
14 4274 71a0b41 464.041
15 4277 13582fc 516.715

Performance for Pop() in tcp-ping-pong-client

Diff since root commit.

Diff Commit Catnap
0 4226 5b5bf06 396.44
1 4228 2b949e3 413.111
2 4234 cd2a133 592.77
3 4236 3dee402 442.926
4 4238 540c178 384.613
5 4241 fc96ac0 397.613
6 4244 b7ee223 375.974
7 4247 dca2919 385.9
8 4254 c25fdd5 366.234
9 4258 0fcdcdc 379.738
10 4265 e3f3442 379.214
11 4267 4b1ed79 391.97
12 4270 ffaf885 373.839
13 4272 c420595 373.293
14 4274 71a0b41 387.314
15 4277 13582fc 585.072

@anandbonde anandbonde merged commit 9eb25d9 into dev May 16, 2024
17 checks passed
@anandbonde anandbonde deleted the workaround-ab-timer-resolution-manual-tuning branch May 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants