Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[inetstack] Properly close connecting sockets #1304

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[inetstack] Properly close connecting sockets #1304

merged 1 commit into from
Jun 12, 2024

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Jun 6, 2024 •
edited
Loading

This PR closes #597. It also adds all integration tests for Catpowder and Catnip. Closes #612 and closes #611

@iyzhang iyzhang requested review from anandbonde and ppenna June 6, 2024 21:24
@iyzhang iyzhang self-assigned this Jun 6, 2024
@iyzhang iyzhang force-pushed the bugfix-inetstack-close-connecting-socket branch 3 times, most recently from 9c381cb to eab4555 Compare June 7, 2024 22:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

libos = catnip
commit id = eab4555

fn percent_time mean_cycles_per_call mean_ns_per_call
inetstack::poll_bg_work::for::receive 66.90 9265.87 4282.94
demikernel::new 58.82 1813423889.70 838822555.14
inetstack::poll_recv 35.93 481.91 223.28
tcp::established::background::retransmitter 33.51 1382.99 632.88
tcp::established::background::sender 23.06 842.29 386.28
tcp::established::background::receiver 20.53 629.50 289.52
tcp::established::background::acknowledger 10.93 404.57 185.55
inetstack::poll_bg_work::for::for 8.45 607.50 282.44
udp::receive 7.41 368.65 177.80
Inetstack::TCP::established::background 4.19 3547.97 1627.10
NetworkLibOS::pop 0.74 1021.63 469.07
NetworkLibOS::push 0.54 2147.81 988.18
inetstack::poll 0.34 40979.35 18951.24
demikernel::push 0.16 661.78 304.32
demikernel::sgaalloc 0.12 255.87 116.28
NetworkLibOS::pushto 0.08 1171.44 581.13
demikernel::pop 0.08 397.74 183.84
demikernel::pushto 0.03 418.43 203.63
NetworkLibOS::connect 0.01 22179.61 10232.98
NetworkLibOS::close 0.01 8801.44 4186.03
demikernel::sgafree 0.01 64.74 30.17
Inetstack::TCP::passiveopen::background 0.00 22029.37 10247.82
demikernel::bind 0.00 10457.91 4809.92
passive_listening::poll 0.00 7535.59 3472.02
demikernel::connect 0.00 5134.78 2332.67
demikernel::listen 0.00 4938.22 2261.59
NetworkLibOS::accept 0.00 3180.99 1459.97
Inetstack::arp::background 0.00 3036.51 1407.04
Inetstack::ICMP::background 0.00 2936.92 1360.62
demikernel::accept 0.00 1819.68 845.46
demikernel::socket 0.00 1440.12 710.55
demikernel::close 0.00 nan nan

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

libos = catnap
commit id = eab4555

fn percent_time mean_cycles_per_call mean_ns_per_call
catnap::transport::epoll 94.74 2242.14 1036.30
NetworkLibOS::pushto 4.77 459.32 224.31
demikernel::pushto 2.19 422.23 205.52
NetworkLibOS::connect 1.82 41924.26 20247.66
demikernel::new 1.30 1606380.56 736411.17
NetworkLibOS::push 1.04 684.57 314.33
NetworkLibOS::pop 0.61 663.18 300.94
demikernel::push 0.59 597.82 275.41
demikernel::sgaalloc 0.55 241.27 120.27
demikernel::pop 0.41 664.24 302.15
demikernel::socket 0.33 58398.32 26860.50
NetworkLibOS::close 0.25 23383.89 10842.34
demikernel::sgafree 0.09 73.81 33.70
demikernel::async_close 0.07 882.62 380.58
demikernel::connect 0.04 2159.30 1051.86
demikernel::bind 0.02 36583.85 16580.70
demikernel::listen 0.00 14291.26 6460.34
NetworkLibOS::accept 0.00 7356.00 3325.55
demikernel::accept 0.00 1763.95 799.09
demikernel::close 0.00 nan nan

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

libos = catpowder
commit id = eab4555

fn percent_time mean_cycles_per_call mean_ns_per_call
inetstack::poll_bg_work::for::receive 76.15 3795.05 1666.60
inetstack::poll_recv 58.74 1136.66 498.10
demikernel::new 39.16 90233666.04 39719570.92
tcp::established::background::receiver 37.18 3167.39 1364.62
tcp::established::background::retransmitter 19.29 1202.08 522.59
tcp::established::background::sender 17.91 1200.16 521.13
udp::receive 14.72 464.94 200.33
tcp::established::background::acknowledger 7.33 438.92 190.81
inetstack::poll_bg_work::for::for 4.46 244.03 106.71
NetworkLibOS::pushto 4.12 5172.20 2225.29
NetworkLibOS::push 1.65 6419.74 2875.24
Inetstack::TCP::established::background 0.62 6193.53 2681.25
demikernel::pushto 0.35 457.40 196.85
inetstack::poll 0.14 8794.50 3860.90
demikernel::push 0.14 656.37 292.60
demikernel::sgaalloc 0.10 243.08 114.89
NetworkLibOS::pop 0.08 1303.78 564.64
NetworkLibOS::connect 0.07 37383.00 16698.07
demikernel::pop 0.04 981.57 425.98
NetworkLibOS::close 0.02 12308.60 5433.31
demikernel::sgafree 0.02 87.98 38.62
demikernel::connect 0.01 11000.00 4883.11
Inetstack::TCP::passiveopen::background 0.00 24747.00 10736.80
demikernel::bind 0.00 9310.43 4030.79
passive_listening::poll 0.00 7866.89 3418.51
demikernel::listen 0.00 4638.60 2013.55
NetworkLibOS::accept 0.00 4153.80 1799.15
Inetstack::ICMP::background 0.00 2882.25 1261.23
Inetstack::arp::background 0.00 2428.00 1059.63
demikernel::async_close 0.00 2268.58 979.33
demikernel::accept 0.00 2122.90 920.19
demikernel::socket 0.00 1678.83 735.92
demikernel::close 0.00 nan nan

@ppenna ppenna changed the title Bug Fix: Properly close connecting sockets [inetstack] Properly close connecting sockets Jun 12, 2024
@ppenna ppenna added the bug Something Isn't Working label Jun 12, 2024
@ppenna ppenna force-pushed the bugfix-inetstack-close-connecting-socket branch from eab4555 to 5213d8b Compare June 12, 2024 20:09
@github-actions GitHub Actions
Copy link

libos = catpowder
commit id = 5213d8b

fn percent_time mean_cycles_per_call mean_ns_per_call
inetstack::poll_bg_work::for::receive 76.32 3455.70 1549.96
inetstack::poll_recv 60.12 1121.94 498.77
demikernel::new 37.96 89422175.33 40045624.26
tcp::established::background::receiver 36.58 2986.47 1294.82
udp::receive 19.70 426.98 190.63
tcp::established::background::retransmitter 19.08 1151.60 503.05
tcp::established::background::sender 18.15 1244.62 541.92
tcp::established::background::acknowledger 7.47 480.55 209.80
inetstack::poll_bg_work::for::for 4.39 209.92 93.49
NetworkLibOS::pushto 2.87 5025.14 2208.51
NetworkLibOS::push 1.66 8752.79 3963.65
Inetstack::TCP::established::background 0.61 6149.32 2677.72
demikernel::pushto 0.24 431.99 189.85
demikernel::push 0.14 627.70 286.49
demikernel::sgaalloc 0.10 211.99 95.68
inetstack::poll 0.08 7969.25 3571.37
NetworkLibOS::pop 0.08 1163.80 512.67
NetworkLibOS::connect 0.06 36376.60 16156.05
demikernel::pop 0.04 1152.94 509.32
NetworkLibOS::close 0.02 12176.00 5408.14
demikernel::sgafree 0.02 85.25 37.97
demikernel::connect 0.01 7923.40 3510.85
Inetstack::TCP::passiveopen::background 0.00 23658.30 10557.63
demikernel::bind 0.00 8655.14 3869.50
passive_listening::poll 0.00 8413.58 3763.74
demikernel::listen 0.00 6083.60 2723.84
NetworkLibOS::accept 0.00 4061.40 1814.52
Inetstack::arp::background 0.00 2866.09 1273.07
Inetstack::ICMP::background 0.00 2765.08 1233.93
demikernel::accept 0.00 2445.00 1091.51
demikernel::socket 0.00 2214.08 978.69
demikernel::async_close 0.00 2003.75 861.31
demikernel::close 0.00 nan nan

@github-actions GitHub Actions
Copy link

libos = catnip
commit id = 5213d8b

fn percent_time mean_cycles_per_call mean_ns_per_call
inetstack::poll_bg_work::for::receive 67.09 9166.34 4215.12
demikernel::new 59.16 1819465675.72 836397564.39
inetstack::poll_recv 35.61 477.97 219.90
tcp::established::background::retransmitter 33.68 1401.73 670.49
tcp::established::background::sender 22.99 848.20 403.52
tcp::established::background::receiver 20.31 622.96 292.75
tcp::established::background::acknowledger 11.18 412.42 196.12
inetstack::poll_bg_work::for::for 8.32 589.79 271.95
Inetstack::TCP::established::background 4.12 3572.75 1695.78
udp::receive 2.63 432.34 196.91
NetworkLibOS::pop 0.74 1021.56 485.88
NetworkLibOS::push 0.54 2185.53 1013.13
inetstack::poll 0.27 40572.40 18667.48
NetworkLibOS::pushto 0.17 1193.48 535.78
demikernel::push 0.16 657.29 303.65
demikernel::sgaalloc 0.13 273.64 131.25
demikernel::pop 0.08 401.57 184.99
demikernel::pushto 0.07 427.07 192.22
demikernel::sgafree 0.02 64.75 29.87
NetworkLibOS::connect 0.01 21591.71 9760.23
NetworkLibOS::close 0.01 8836.15 4004.97
Inetstack::TCP::passiveopen::background 0.00 23218.73 10244.89
demikernel::bind 0.00 11783.09 5414.35
passive_listening::poll 0.00 7723.54 3439.50
demikernel::connect 0.00 4729.67 2079.67
demikernel::listen 0.00 4340.33 1967.86
NetworkLibOS::accept 0.00 3188.03 1429.61
Inetstack::ICMP::background 0.00 2940.58 1348.69
Inetstack::arp::background 0.00 2872.43 1309.54
demikernel::accept 0.00 2001.66 886.21
demikernel::socket 0.00 1706.05 777.26
demikernel::close 0.00 nan nan

@github-actions GitHub Actions
Copy link

libos = catnap
commit id = 5213d8b

fn percent_time mean_cycles_per_call mean_ns_per_call
catnap::transport::epoll 94.14 2310.50 1046.05
NetworkLibOS::pushto 4.79 468.09 204.18
NetworkLibOS::connect 2.25 45334.34 20342.67
demikernel::pushto 2.24 453.25 197.59
demikernel::new 1.56 1676982.73 747832.40
NetworkLibOS::push 1.04 719.74 323.03
NetworkLibOS::pop 0.63 712.45 317.32
demikernel::push 0.57 606.89 272.48
demikernel::sgaalloc 0.56 255.37 115.72
demikernel::pop 0.47 723.00 322.71
demikernel::socket 0.40 62089.28 27703.89
NetworkLibOS::close 0.30 24029.64 10714.08
demikernel::sgafree 0.09 73.99 33.07
demikernel::async_close 0.08 1017.37 435.68
demikernel::connect 0.05 2554.62 1148.99
demikernel::bind 0.01 36744.35 16385.85
demikernel::listen 0.00 14151.16 6307.66
NetworkLibOS::accept 0.00 7261.13 3232.62
demikernel::accept 0.00 1850.18 827.03
demikernel::close 0.00 nan nan

ppenna
ppenna approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna merged commit 7ae419f into dev Jun 12, 2024
17 checks passed
@ppenna ppenna deleted the bugfix-inetstack-close-connecting-socket branch June 12, 2024 21:02
@iyzhang iyzhang mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@iyzhang iyzhang

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
2 participants
@iyzhang @ppenna