Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catloop] Warn msg correction #747

Merged
merged 1 commit into from
May 30, 2023
Merged

[catloop] Warn msg correction #747

merged 1 commit into from
May 30, 2023

Conversation

anandbonde
Copy link
Contributor

The message was misleading us to think that the client was invoking accept() in the logs.

@anandbonde anandbonde requested a review from iyzhang May 24, 2023 19:28
@anandbonde anandbonde self-assigned this May 24, 2023
iyzhang
iyzhang approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@ppenna ppenna self-requested a review May 30, 2023 11:53
@anandbonde anandbonde force-pushed the bugfix-accept-msg-in-connect-catloop branch from 6d6c798 to 55ead68 Compare May 30, 2023 16:52
@anandbonde anandbonde merged commit bb2f710 into dev May 30, 2023
10 checks passed
@anandbonde anandbonde deleted the bugfix-accept-msg-in-connect-catloop branch May 30, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

@iyzhang iyzhang iyzhang approved these changes

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandbonde @ppenna @iyzhang