Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Enable All Async Close Tests for TCP #780

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jun 20, 2023

Summary of Changes

  • Fixed async_close tests for TCP
    • We were not considering that a second call on the same queue token could return EBADF.
  • Enabled async_close tests for TCP
  • Cleanup test output
    • We do not need to have the print statement on each test, because the crate::test!() macro does this job better.
  • Moved async_close tests to its own directory, to match the source tree standard that we have for other tests.
  • Moved wait tests to its own directory, to match the source tree standard that we have for other tests.

@ppenna ppenna added bug Something Isn't Working enhancement Enhancement Request on an Existing Feature labels Jun 20, 2023
@ppenna ppenna self-assigned this Jun 20, 2023
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iyzhang iyzhang force-pushed the bugfix-test-tcp-async-close branch from b2a8f3c to f82a31a Compare June 22, 2023 01:45
@iyzhang iyzhang merged commit 56935c7 into dev Jun 22, 2023
11 checks passed
@iyzhang iyzhang deleted the bugfix-test-tcp-async-close branch June 22, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants