Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catmem] Missing async_close #783

Merged
merged 3 commits into from
Jun 22, 2023
Merged

[catmem] Missing async_close #783

merged 3 commits into from
Jun 22, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jun 21, 2023

Description

Summary of Changes

  • Implemented async_close() for Catmem LibOS
  • Fixed async close tests on pipes
  • Enabled standalone tests for Catmem LibOS

@ppenna ppenna self-assigned this Jun 21, 2023
@ppenna ppenna added the bug Something Isn't Working label Jun 21, 2023
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus those small comments

src/rust/catmem/futures/close.rs Outdated Show resolved Hide resolved
src/rust/catmem/futures/close.rs Outdated Show resolved Hide resolved
@ppenna ppenna changed the title Bugfix catmem async close [catmem] Missing async_close Jun 22, 2023
@ppenna ppenna force-pushed the bugfix-catmem-async-close branch from 646cb45 to 03d6554 Compare June 22, 2023 10:47
@ppenna ppenna merged commit 8bb62ba into dev Jun 22, 2023
11 checks passed
@ppenna ppenna deleted the bugfix-catmem-async-close branch June 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something Isn't Working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[catmem] Missing async_close()
2 participants