Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Missing cases on IPv4 test-unit #784

Merged
merged 3 commits into from
Jun 22, 2023
Merged

[test] Missing cases on IPv4 test-unit #784

merged 3 commits into from
Jun 22, 2023

Conversation

carvalhof
Copy link
Contributor

Description

This PR closes #781.

Summary of Changes

  • Updated the upper bound of the for in the test_ipv4_header_parse_good test to include the value 15.
  • Added the header length in the build_ipv4_header function.
  • Verified the minimum size of the buffer in the compute_checksum function.

@ppenna ppenna self-requested a review June 22, 2023 11:31
@ppenna ppenna self-assigned this Jun 22, 2023
ppenna
ppenna approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna added the bug Something Isn't Working label Jun 22, 2023
@ppenna ppenna merged commit 71dc394 into dev Jun 22, 2023
11 checks passed
@ppenna ppenna deleted the bugfix-test-ipv4 branch June 22, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppenna ppenna ppenna approved these changes

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] Missing cases on IPv4 test-unit
2 participants
@carvalhof @ppenna