Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catloop] Missing to Shift Catmem Queue Tokens When Packing Result #791

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[catloop] Missing to Shift Catmem Queue Tokens When Packing Result #791

merged 1 commit into from
Jun 23, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jun 22, 2023

@ppenna ppenna added the bug Something Isn't Working label Jun 22, 2023
@ppenna ppenna self-assigned this Jun 22, 2023
iyzhang
iyzhang approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider making the Catmem queue tokens the ones that are shifted as they are the ones that are not externally visible. Then we will not have to make any external changes when we move to a single shared scheduler.

@ppenna
Copy link
Contributor Author

ppenna commented Jun 23, 2023

We should consider making the Catmem queue tokens the ones that are shifted as they are the ones that are not externally visible. Then we will not have to make any external changes when we move to a single shared scheduler.

Indeed, but that would also fix once we get full support for multiple liboses to co-exist - the queue token space will not overlap after that, right?

@ppenna ppenna force-pushed the bugfix-catloop-pack-result branch from e0fd2c7 to b4b8060 Compare June 23, 2023 11:31
@ppenna ppenna merged commit 0a70252 into dev Jun 23, 2023
11 checks passed
@ppenna ppenna deleted the bugfix-catloop-pack-result branch June 23, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@anandbonde anandbonde Awaiting requested review from anandbonde

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[catloop] Missing to Shift Catmem Queue Tokens When Packing Result
2 participants
@ppenna @iyzhang