Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[catloop] Missing async_close() #816

Merged
merged 2 commits into from
Jul 12, 2023
Merged

[catloop] Missing async_close() #816

merged 2 commits into from
Jul 12, 2023

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Jul 5, 2023

Description

This PR closes #812.

@ppenna ppenna added the bug Something Isn't Working label Jul 5, 2023
@ppenna ppenna requested a review from iyzhang July 5, 2023 15:37
@ppenna ppenna self-assigned this Jul 5, 2023
@ppenna ppenna force-pushed the bugfix-catloop-async-close branch from 735bae6 to dab07d7 Compare July 6, 2023 09:47
@ppenna ppenna mentioned this pull request Jul 6, 2023
Closed
iyzhang
iyzhang requested changes Jul 6, 2023
View reviewed changes
src/rust/catloop/mod.rs Show resolved Hide resolved
src/rust/catloop/mod.rs Show resolved Hide resolved
@ppenna ppenna force-pushed the bugfix-catloop-async-close branch from dab07d7 to 2cdbdc4 Compare July 11, 2023 10:43
@ppenna ppenna requested a review from iyzhang July 11, 2023 10:44
iyzhang
iyzhang approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining!

anandbonde
anandbonde reviewed Jul 12, 2023
View reviewed changes
src/rust/catloop/mod.rs Outdated Show resolved Hide resolved
@ppenna ppenna force-pushed the bugfix-catloop-async-close branch from 5f68bef to 838e268 Compare July 12, 2023 17:34
@ppenna ppenna merged commit 4a4ccc0 into dev Jul 12, 2023
11 checks passed
@ppenna ppenna deleted the bugfix-catloop-async-close branch July 12, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde anandbonde approved these changes

@iyzhang iyzhang iyzhang approved these changes

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[catloop] Missing async_close()
3 participants
@ppenna @anandbonde @iyzhang