[catloop] Close new duplex pipe when not MAGIC_CONNECT #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
force-pushed
the
bugfix-catloop-close-pipes
branch
from
2163128
to
032308d
Compare
ppenna
changed the title
iyzhang
force-pushed
the
bugfix-catloop-close-pipes
branch
from
032308d
to
28ccab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first value that the server expects to receive on any new duplex pipe is MAGIC_CONNECT to validate that the client is using the right port. If we receive anything else, we should close the duplex_pipe and move on to the next request. This PR closes #778