Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scheduler] Deprecate TaskHandle.deschedule() #839

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[scheduler] Deprecate TaskHandle.deschedule() #839

merged 1 commit into from
Jul 11, 2023

Conversation

anandbonde
Copy link
Contributor

We discussed offline that TaskHandle.deschedule() should be deprecated.

@anandbonde anandbonde requested a review from iyzhang July 10, 2023 21:13
@anandbonde anandbonde self-assigned this Jul 10, 2023
@anandbonde anandbonde requested a review from ppenna July 10, 2023 22:00
@anandbonde anandbonde force-pushed the enhancement-ab-deprecated-deschedule branch from 8401106 to bbbbdf5 Compare July 10, 2023 22:33
iyzhang
iyzhang approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@iyzhang iyzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iyzhang iyzhang merged commit 9789da9 into dev Jul 11, 2023
11 checks passed
@iyzhang iyzhang deleted the enhancement-ab-deprecated-deschedule branch July 11, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyzhang iyzhang iyzhang approved these changes

@ppenna ppenna Awaiting requested review from ppenna

Assignees

@anandbonde anandbonde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anandbonde @iyzhang