Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[catnap] Enhancement: More compact state machine code #844

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Jul 11, 2023

This PR moves code that was dispersed into a more compact state machine. It closes #843

@iyzhang iyzhang added the enhancement Enhancement Request on an Existing Feature label Jul 11, 2023
@iyzhang iyzhang self-assigned this Jul 11, 2023
@iyzhang iyzhang force-pushed the enhancement-catnap-state-machine branch from 8fb4f39 to 5f8b043 Compare July 11, 2023 21:57
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/rust/catnap/socket.rs Outdated Show resolved Hide resolved
src/rust/catnap/socket.rs Outdated Show resolved Hide resolved
src/rust/catnap/socket.rs Outdated Show resolved Hide resolved
@iyzhang iyzhang merged commit c2fbe2b into dev Jul 12, 2023
11 checks passed
@iyzhang iyzhang deleted the enhancement-catnap-state-machine branch July 12, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[catnap] More compact representation of state machine in Socket
3 participants