[catnap] Enhancement: re-architect Catnap #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandbonde
approved these changes
Jul 20, 2023
iyzhang
force-pushed
the
enhancement-catnap-reorg
branch
3 times, most recently
from
2071efe
to
315bfaa
Compare
ppenna
reviewed
Jul 21, 2023
ppenna
reviewed
Jul 21, 2023
ppenna
force-pushed
the
enhancement-catnap-reorg
branch
2 times, most recently
from
ca2278a
to
427e7d2
Compare
Merged
ppenna
force-pushed
the
enhancement-catnap-reorg
branch
3 times, most recently
from
93d0bb1
to
aa7f0c1
Compare
ppenna
force-pushed
the
enhancement-catnap-reorg
branch
from
aa7f0c1
to
eac97e9
Compare
iyzhang
commented
Jul 28, 2023
ppenna
force-pushed
the
enhancement-catnap-reorg
branch
from
eac97e9
to
2cc0fa0
Compare
ppenna
force-pushed
the
enhancement-catnap-reorg
branch
from
2cc0fa0
to
d8109a5
Compare
ppenna
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-architects the Catnap libOS such that the libOS follows an object-oriented architecture where the libOS aggregates CatnapQueues but does not know about sockets or the libc calls. The Socket is composed by CatnapQueue but CatnapQueue does not know about libc. And all libc syscalls are encapsulated inside Socket. Thus there is a strict encapsulation hierarchy, where each level only knows the level below: CatnapLibOS encapsulates-> CatnapQueue encapsulates-> Socket encapsulates-> libc syscalls.