-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[catnap] Move states and YielderHandle allocation into CatnapQueue #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
force-pushed
the
enhancement-catnap-queue-reorg
branch
from
July 29, 2023 23:45
2e2e022
to
b75b201
Compare
iyzhang
changed the title
[catnap] Enhancement: Re-architecture
[catnap] Enhancement: Move states and YielderHandle allocation into CatnapQueue
Jul 30, 2023
iyzhang
force-pushed
the
enhancement-catnap-queue-reorg
branch
from
July 30, 2023 00:47
b75b201
to
79cf8bd
Compare
ppenna
changed the title
[catnap] Enhancement: Move states and YielderHandle allocation into CatnapQueue
[catnap] Move states and YielderHandle allocation into CatnapQueue
Jul 31, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
reviewed
Aug 1, 2023
anandbonde
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments.
ppenna
force-pushed
the
enhancement-catnap-queue-reorg
branch
from
August 4, 2023 16:59
79cf8bd
to
f84e864
Compare
ppenna
force-pushed
the
enhancement-catnap-queue-reorg
branch
from
August 4, 2023 18:34
f84e864
to
941bd61
Compare
anandbonde
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
ppenna
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Catnap libOS towards our eventual architecture. There are a few important steps that this PR implements:
After this PR the following guidelines are recommended for our architecture: