[catmem] Mutex locking #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
added
bug
ppenna
reviewed
Aug 7, 2023
ppenna
reviewed
Aug 7, 2023
ppenna
reviewed
Aug 7, 2023
anandbonde
reviewed
Aug 7, 2023
anandbonde
reviewed
Aug 7, 2023
ppenna
force-pushed
the
enhancement-scheduler-mutex
branch
from
9d0a55d
to
960ec8c
Compare
ppenna
force-pushed
the
enhancement-scheduler-mutex
branch
from
960ec8c
to
cebc079
Compare
ppenna
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple mutex to the scheduler that can be used to guarantee serialized access to the data structure. The mutex can either be used by polling it or passing in a yielder that will yield back to the scheduler if the mutex is currently locked. This PR is a fix to issue #842, although all the producers must be in a single process and all consumers as well.