[runtime] Move scheduler to shared runtime #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyzhang
force-pushed
the
wip-enhancement-runtime-move-scheduler
branch
from
414cd73
to
1f76a08
Compare
ppenna
changed the title
anandbonde
approved these changes
Aug 10, 2023
iyzhang
force-pushed
the
wip-enhancement-runtime-move-scheduler
branch
from
ed7904f
to
34e0487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR encapsulates the scheduler in the runtime (removes its public visibility) and creates a shared DemiRuntime abstraction to hold it. The DemiRuntime is allocated in the Demikernel library level and passed into each libOS. The DemiRuntime implements the Runtime trait and the MemoryRuntime trait, so it can be used for both coroutine scheduling and memory allocation. It is cloneable and the scheduler is currently using dynamic runtime checks for borrowing, so libOSes can safely share as long as only one libOS is using it at a time.